attributes/codegen: update aarch64 features#1791
Merged
ehuss merged 1 commit intorust-lang:masterfrom Apr 17, 2025
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Contributor
|
Thanks for updating this! I noticed that this adds a "Stability" column. We have a policy here of not documenting unstable features. Can you remove the unstable entries and the new column? Unstable features should usually be documented in the unstable book. |
ehuss
added
S-waiting-on-stabilization
davidtwco
force-pushed
the
feature-detect
branch
from
df1159b to
e5d7d7c
Compare
Member
Author
|
Ah, my bad, fixed! |
ehuss
added
S-waiting-on-review
Update `attributes/codegen.md` to match aarch64 CPU features known to rustc[1]. [1]: https://github.com/rust-lang/rust/blob/afa859f8121bf2985362a2c8414dc71a825ccf2d/compiler/rustc_target/src/target_features.rs#L179-L373
ehuss
reviewed
Apr 17, 2025
src/attributes/codegen.md
Outdated
Comment on lines
229
to
230
| Feature | Implicity Enables | Feature Name | ||
| ------- | ----------------- | ------------ |
Contributor
There was a problem hiding this comment.
Implicitly is now misspelled.
Also, can you remove all the addition of spaces in the table? It doesn't look like any of them are needed.
src/attributes/codegen.md
Outdated
Comment on lines
269
to
272
| `sve2-aes` | `sve2` `aes`, | FEAT_SVE_AES & FEAT_SVE_PMULL128 --- SVE AES instructions | ||
| `sve2-bitperm` | `sve2` | FEAT_SVE2_BitPerm --- SVE Bit Permute | ||
| `sve2-sha3` | `sve2` `sha3`, | FEAT_SVE2_SHA3 --- SVE SHA3 instructions | ||
| `sve2-sm4` | `sve2` `sm4`, | FEAT_SVE2_SM4 --- SVE SM4 instructions |
Contributor
There was a problem hiding this comment.
The commas in the implicit table here seem to have gotten shifted around.
ehuss
added
S-waiting-on-author
davidtwco
force-pushed
the
feature-detect
branch
2 times, most recently
from
a909966 to
d9b390d
Compare
ehuss
approved these changes
Apr 17, 2025
Contributor
ehuss
left a comment
ehuss
left a comment
There was a problem hiding this comment.
Thanks!
Also confirmed with https://github.com/llvm/llvm-project/blob/b30100b87f24847afd6407b4939a184ebcf16ef9/llvm/lib/Target/AArch64/AArch64Features.td.
I'll note that I'm not exactly sure this is a complete replacement for #1546, since I was assuming the intent there was to prepare the documentation for the stabilization of remaining aarch64_unstable_target_feature features. However, that wasn't clear to me, and I don't know if any of those features are on track to get stabilized anytime soon.
ChrisDenton
added a commit
to ChrisDenton/rust
that referenced
this pull request
Apr 22, 2025
Update books ## rust-lang/nomicon 1 commits in 0c10c30cc54736c5c194ce98c50e2de84eeb6e79..c76a20f0d987145dcedf05c5c073ce8d91f2e82a 2025-04-15 20:54:57 UTC to 2025-04-15 20:54:57 UTC - Say that dereferencing a pointer to a ZST is no longer undefined (rust-lang/nomicon#467) ## rust-lang/reference 7 commits in 3340922df189bddcbaad17dc3927d51a76bcd5ed..3bf3402aea982b876eb56c87da17b0685c6461d5 2025-04-18 13:44:45 UTC to 2025-04-17 17:27:01 UTC - Use `cfg(false)` instead of `cfg(FALSE)` (rust-lang/reference#1763) - Add `cfg(true)` and `cfg(false)` to conditional compilation (RFC 3695) (rust-lang/reference#1762) - Refactor rendering with `RenderCtx` (rust-lang/reference#1796) - attributes/codegen: update aarch64 features (rust-lang/reference#1791) - Simplify GenericParams grammar (rust-lang/reference#1795) - Add rule identifiers for the ABI chapter (rust-lang/reference#1793) - Remove broken footnote links from grammar summary (rust-lang/reference#1794)
ChrisDenton
added a commit
to ChrisDenton/rust
that referenced
this pull request
Apr 22, 2025
Update books ## rust-lang/nomicon 1 commits in 0c10c30cc54736c5c194ce98c50e2de84eeb6e79..c76a20f0d987145dcedf05c5c073ce8d91f2e82a 2025-04-15 20:54:57 UTC to 2025-04-15 20:54:57 UTC - Say that dereferencing a pointer to a ZST is no longer undefined (rust-lang/nomicon#467) ## rust-lang/reference 7 commits in 3340922df189bddcbaad17dc3927d51a76bcd5ed..3bf3402aea982b876eb56c87da17b0685c6461d5 2025-04-18 13:44:45 UTC to 2025-04-17 17:27:01 UTC - Use `cfg(false)` instead of `cfg(FALSE)` (rust-lang/reference#1763) - Add `cfg(true)` and `cfg(false)` to conditional compilation (RFC 3695) (rust-lang/reference#1762) - Refactor rendering with `RenderCtx` (rust-lang/reference#1796) - attributes/codegen: update aarch64 features (rust-lang/reference#1791) - Simplify GenericParams grammar (rust-lang/reference#1795) - Add rule identifiers for the ABI chapter (rust-lang/reference#1793) - Remove broken footnote links from grammar summary (rust-lang/reference#1794)
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 23, 2025
Rollup merge of rust-lang#140124 - rustbot:docs-update, r=ehuss Update books ## rust-lang/nomicon 1 commits in 0c10c30cc54736c5c194ce98c50e2de84eeb6e79..c76a20f0d987145dcedf05c5c073ce8d91f2e82a 2025-04-15 20:54:57 UTC to 2025-04-15 20:54:57 UTC - Say that dereferencing a pointer to a ZST is no longer undefined (rust-lang/nomicon#467) ## rust-lang/reference 7 commits in 3340922df189bddcbaad17dc3927d51a76bcd5ed..3bf3402aea982b876eb56c87da17b0685c6461d5 2025-04-18 13:44:45 UTC to 2025-04-17 17:27:01 UTC - Use `cfg(false)` instead of `cfg(FALSE)` (rust-lang/reference#1763) - Add `cfg(true)` and `cfg(false)` to conditional compilation (RFC 3695) (rust-lang/reference#1762) - Refactor rendering with `RenderCtx` (rust-lang/reference#1796) - attributes/codegen: update aarch64 features (rust-lang/reference#1791) - Simplify GenericParams grammar (rust-lang/reference#1795) - Add rule identifiers for the ABI chapter (rust-lang/reference#1793) - Remove broken footnote links from grammar summary (rust-lang/reference#1794)
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Apr 23, 2025
Update books ## rust-lang/nomicon 1 commits in 0c10c30cc54736c5c194ce98c50e2de84eeb6e79..c76a20f0d987145dcedf05c5c073ce8d91f2e82a 2025-04-15 20:54:57 UTC to 2025-04-15 20:54:57 UTC - Say that dereferencing a pointer to a ZST is no longer undefined (rust-lang/nomicon#467) ## rust-lang/reference 7 commits in 3340922df189bddcbaad17dc3927d51a76bcd5ed..3bf3402aea982b876eb56c87da17b0685c6461d5 2025-04-18 13:44:45 UTC to 2025-04-17 17:27:01 UTC - Use `cfg(false)` instead of `cfg(FALSE)` (rust-lang/reference#1763) - Add `cfg(true)` and `cfg(false)` to conditional compilation (RFC 3695) (rust-lang/reference#1762) - Refactor rendering with `RenderCtx` (rust-lang/reference#1796) - attributes/codegen: update aarch64 features (rust-lang/reference#1791) - Simplify GenericParams grammar (rust-lang/reference#1795) - Add rule identifiers for the ABI chapter (rust-lang/reference#1793) - Remove broken footnote links from grammar summary (rust-lang/reference#1794)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes #1546.
Update
attributes/codegen.mdto match aarch64 CPU features known to rustc.