Update guarantees of unwinding past an extern "C" function#887
Update guarantees of unwinding past an extern "C" function#887yuriks wants to merge 1 commit intorust-lang:masterfrom
Conversation
The current docs say it will abort, however that behavior was actually reverted in rust-lang/rust#48445 and is not what currently happens in stable.
| > **Note**: Currently, in nightly `rustc` the LLVM backend aborts the process | ||
| > by executing an illegal instruction. However, this is not the behavior in stable. |
There was a problem hiding this comment.
We generally don't include notes about specific versions of the rustc compiler in the reference. I'm also not sure what this is referring to, since it no longer aborts on unwind.
| with such ABIs causes the process to abort. | ||
| Functions with an ABI that differs from `"Rust"` do not support unwinding in | ||
| the exact same way that Rust does. Therefore, unwinding past the end of | ||
| functions with such ABIs results in undefined behavior, and will differ between |
There was a problem hiding this comment.
Can you link undefined behavior to behavior-considered-undefined.md?
| Functions with an ABI that differs from `"Rust"` do not support unwinding in | ||
| the exact same way that Rust does. Therefore, unwinding past the end of | ||
| functions with such ABIs results in undefined behavior, and will differ between | ||
| platforms and compiler editions. If you cannot guarantee this will not happen, |
There was a problem hiding this comment.
I'm not sure what "compiler editions" means here. "Edition" has a specific meaning in Rust, and I don't think that is what is being referred to here. I think it would be fine to end the sentence at "undefined behavior", with the link leading the reader to understanding what that means.
ehuss
added
the
S-waiting-on-author
|
☔ The latest upstream changes (possibly bf115a4) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I'm going to close as all the panic/unwinding stuff has been rewritten in #1226. Thanks! |
3 participants
As prompted by discussion in rust-lang/rust#52652
The current docs say it will abort, however that behavior was actually reverted in rust-lang/rust#48445 and is not what currently happens in stable.