Skip to content

RFC: Unreserve proc#2420

Merged
Centril merged 3 commits intorust-lang:masterfrom
Centril:rfc/unreserve-proc
May 14, 2018
Merged

RFC: Unreserve proc#2420
Centril merged 3 commits intorust-lang:masterfrom
Centril:rfc/unreserve-proc

Conversation

@Centril
Copy link
Contributor

@Centril Centril commented Apr 26, 2018 •
edited
Loading

🖼️ Rendered

📝 Summary

The keyword proc gets unreserved.

🎵 Note

This RFC aims to formalize the merged PR rust-lang/rust#49699 which has already implemented this RFC.

@Centril Centril added T-lang Relevant to the language team, which will review and decide on the RFC. I-nominated labels Apr 26, 2018
@aturon
Copy link
Contributor

aturon commented Apr 26, 2018

Thanks @Centril for helping correct this process mistake! Since the implementation PR was already merged, I'm going to go ahead and kick off full review/FCP:

@rfcbot fcp merge

@rfcbot rfcbot added the proposed-final-comment-period Currently awaiting signoff of all team members in order to enter the final comment period. label Apr 26, 2018
@rfcbot
Copy link

rfcbot commented Apr 26, 2018 •
edited by nrc
Loading

Team member @aturon has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@scottmcm
Copy link
Member

scottmcm commented Apr 26, 2018

@rfcbot reviewed

Since this has sortof already happened, I don't have a problem with it.

I do think, however, that it could be worth trying to make a general keyword unreservation policy. Part of me thinks "well, why bother unreserving anything" since not having a particular identifier available is just not that big of a deal.

@Centril
Copy link
Contributor Author

Centril commented Apr 26, 2018 •
edited
Loading

@scottmcm General keyword unreservation policy discussed in #2421 😁.

@rfcbot rfcbot added final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. and removed proposed-final-comment-period Currently awaiting signoff of all team members in order to enter the final comment period. labels Apr 29, 2018
@rfcbot
Copy link

rfcbot commented Apr 29, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot
Copy link

rfcbot commented May 9, 2018

The final comment period, with a disposition to merge, as per the review above, is now complete.

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this RFC. and removed final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. labels May 9, 2018
@Centril Centril merged commit 352abc0 into rust-lang:master May 14, 2018
@Centril
Copy link
Contributor Author

Centril commented May 14, 2018

Huzzah! This RFC is hereby merged.

This was already implemented in rust-lang/rust#49699 and so there's no tracking issue.

@Centril Centril deleted the rfc/unreserve-proc branch May 14, 2018 16:14
@Centril Centril added A-syntax Syntax related proposals & ideas A-keyword Proposals relating to keywords. labels Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-keyword Proposals relating to keywords. A-syntax Syntax related proposals & ideas finished-final-comment-period The final comment period is finished for this RFC. T-lang Relevant to the language team, which will review and decide on the RFC.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Centril @aturon @rfcbot @scottmcm