mark RFC-3192 (aka the 'provide_any' feature) as rejected#3460
Merged
ehuss merged 1 commit intorust-lang:masterfrom Jul 24, 2023
Merged
mark RFC-3192 (aka the 'provide_any' feature) as rejected#3460ehuss merged 1 commit intorust-lang:masterfrom
ehuss merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
Author
Contributor
|
Generally we don't remove RFCs when they are withdrawn. We don't have a formal mechanism for this, but it should be fine to add a notice towards the top explaining what has happened (example). |
ehuss
added
the
not-rfc
Contributor
Author
|
Oh that's good to know and a good idea. I'll update this PR to add a similar notice. Thanks for the pointer! |
waynr
changed the title
Contributor
|
cc @Amanieu, can you review/confirm this is what the libs team wants to say for the status of this RFC? Thanks! |
ehuss
added
the
T-libs-api
Amanieu
approved these changes
Jul 24, 2023
Member
Amanieu
left a comment
Amanieu
left a comment
There was a problem hiding this comment.
Yes, this accurately summarizes the libs-api team decision from rust-lang/rust#96024 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the decision by the libs team not to proceed with the
Providertrait and to merge what's left of RFC 3192 minusProvider(ie theRequestakaDemandtype) into the WIP RFC 2895.For reference to these decisions, please see the following starting points:
provide_anytracking issue commentRendered