unauthenticated @rustbot label T-*#3494
Merged
ehuss merged 1 commit intorust-lang:masterfrom Sep 20, 2023
Merged
Conversation
This is allowed in [`rust-lang/rust`](https://github.com/rust-lang/rust/blob/62d9034a0d571b78e518727d6cb4b090569e5238/triagebot.toml#L12). Others have also expected it to work here: - rust-lang#3490 (comment) - rust-lang#3485 (comment) @rustbot label not-rfc
rustbot
added
the
not-rfc
ehuss
approved these changes
Sep 20, 2023
Contributor
ehuss
left a comment
ehuss
left a comment
There was a problem hiding this comment.
Seems reasonable to me, thanks! The team assigned to an RFC is an important property, but I don't think this is likely going to be abused, and it is easy to repair if a mistake is made, and this can always be reverted if it is a problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is allowed in
rust-lang/rust.Others have also expected it to work in this repo:
constfunctions in traits #3490 (comment)@rustbot label not-rfc