Move to upstream macro_rules! model#6893
Merged
bors[bot] merged 2 commits intorust-lang:masterfrom Dec 15, 2020
jonas-schievink:macros-rules
Merged
Move to upstream macro_rules! model#6893bors[bot] merged 2 commits intorust-lang:masterfrom jonas-schievink:macros-rules
macro_rules! model#6893bors[bot] merged 2 commits intorust-lang:masterfrom
jonas-schievink:macros-rules
Conversation
Contributor
|
Let's merge this before it rotted :) bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
macro_rules!from being treated as a macro invocation to being a first-class item. It also disallows using an additional ident argument for regular macros, som! ident(...);now fails to parse.This matches upstream Rust, and makes the code somewhat simpler by removing repeated "is this a
macro_rules!call" checks. It will also simplify allowing visibilities on macros, which is currently being proposed in rust-lang/rust#78166.