Merged
Conversation
41 tasks
eebb350 to
970f8b6
Compare
emilio
approved these changes
Dec 2, 2024
Contributor
emilio
left a comment
There was a problem hiding this comment.
I didn't review all the test changes but given the patch I'm pretty confident they're just more unsafe keywords. So looks good :)
970f8b6 to
460065e
Compare
Contributor
Author
|
we're getting lots of semantic merge conflicts lately 🤣 |
Contributor
|
I think there might be a bug with the version matching: This is with |
|
Same here with Rust 1.77, this code seems to be enabled by error. |
phial3
pushed a commit
to phial3/ffmpeg-third
that referenced
this pull request
Jan 14, 2025
issue: rust-lang/rust-bindgen#3015 rust-lang/rust-bindgen#2901 error[E0433]: failed to resolve: could not find `offset_of` in mem issue: rust-lang/rust-bindgen#2960 Use unsafe extern instead of extern in blocks for any Rust target after 1.82
alistair23
added a commit
to westerndigitalcorporation/spdm-utils
that referenced
this pull request
Mar 5, 2025
OpenEmbedded now supports Rust 1.82 and using 1.82 for bindgen allows us to support the 2024 eddition [1]. 1: rust-lang/rust-bindgen#3015 Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
alistair23
added a commit
to westerndigitalcorporation/spdm-utils
that referenced
this pull request
Mar 5, 2025
OpenEmbedded now supports Rust 1.82 and using 1.82 for bindgen allows us to support the 2024 eddition [1]. 1: rust-lang/rust-bindgen#3015 Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
alistair23
added a commit
to westerndigitalcorporation/spdm-utils
that referenced
this pull request
Mar 5, 2025
OpenEmbedded now supports Rust 1.82 and using 1.82 for bindgen allows us to support the 2024 eddition [1]. 1: rust-lang/rust-bindgen#3015 Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
1 task
|
This PR isn't working for me on rust 1.85 stable: Edit: nevermind, I had to specify both rust_edition AND rust_target |
Contributor
Hm ... is that a bug then? At least the CLI help says that the edition should be by default compatible with the chosen target: |
qryxip
added a commit
to VOICEVOX/voicevox_core
that referenced
this pull request
May 26, 2025
jedbrown
added a commit
to rsmpi/rsmpi
that referenced
this pull request
Jun 6, 2025
The updated libffi is needed to fix an issue with MacOS 15, and the fix has a side-effect of increasing MSRV to 1.78. See #209 We will stick with bindgen-1.70.1 because bindgen-1.71.1 does not correctlly identify when to avoid using unsafe extern "C" { ... }, which was first added in rust-1.82. rust-lang/rust-bindgen#3015 https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-extern.html
jedbrown
added a commit
to rsmpi/rsmpi
that referenced
this pull request
Jun 10, 2025
The updated libffi is needed to fix an issue with MacOS 15, and the fix has a side-effect of increasing MSRV to 1.78. See #209 We will stick with bindgen-1.70.1 because bindgen-1.71.1 does not correctlly identify when to avoid using unsafe extern "C" { ... }, which was first added in rust-1.82. rust-lang/rust-bindgen#3015 https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-extern.html
jedbrown
added a commit
to rsmpi/rsmpi
that referenced
this pull request
Jun 10, 2025
The updated libffi is needed to fix an issue with MacOS 15, and the fix has a side-effect of increasing MSRV to 1.78. See #209 We will stick with bindgen-1.70.1 because bindgen-1.71.1 does not correctlly identify when to avoid using unsafe extern "C" { ... }, which was first added in rust-1.82. rust-lang/rust-bindgen#3015 https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-extern.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
unsafe_extern_blocksfeature which was stabilized for Rust 1.82.This feature is activated whenever the Rust target is greater or equal than 1.82.
Fixes #2901
cc pgcentralfoundation/pgrx#1810