Fix macOS dyld issue related to git and libiconv#3339
Open
thedataking wants to merge 1 commit intorust-lang:mainfrom
Open
Fix macOS dyld issue related to git and libiconv#3339thedataking wants to merge 1 commit intorust-lang:mainfrom
thedataking wants to merge 1 commit intorust-lang:mainfrom
Conversation
thedataking
force-pushed
the
fix-macos-ci-libiconv
branch
from
da831be to
8e49134
Compare
thedataking
force-pushed
the
fix-macos-ci-libiconv
branch
from
8e49134 to
6dddd65
Compare
Contributor
|
Instead of unsetting the entire variable, would it be possible to prepend the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS,
DYLD_LIBRARY_PATHis set but does not include the homebrew version oflibiconvwhich is needed by the homebrew version ofgit(invoked inci/test.shbyassert_no_diff). I do not think that bindgen sets this variable in its Github Actions test harness, so pressumably this is set by the runner image on macOS for some reason.A simple fix is to unset it unconditionally regardless of the Runner OS and it appears to fully resolve the problem. I'm not very familiar with the bindgen test setup or GHA runners for macOS so happy to revise the PR.
I checked the issue tracker of the GHA runners repo here https://github.com/actions/runner-images/issues and didn't find anything related to this issue.