Link to rustc_driver crate in plugin#3564
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 20, 2018
Merged
Conversation
Member
|
Looks like this needs reformatting +++cargo +nightly fmt --all -- --check
Diff in /home/travis/build/rust-lang/rust-clippy/src/lib.rs at line 16:
// FIXME: switch to something more ergonomic here, once available.
// (currently there is no way to opt into sysroot crates w/o `extern crate`)
#[allow(unused_extern_crates)]
-extern crate rustc_plugin;
-#[allow(unused_extern_crates)]
extern crate rustc_driver;
+#[allow(unused_extern_crates)]
+extern crate rustc_plugin;
use self::rustc_plugin::Registry;
#[plugin_registrar] |
This is in anticipation for rust-lang/rust#56987 where the `rustc_driver` crate being linked in will be required to link correctly against the compiler. In the meantime it should be harmless otherwise!
alexcrichton
force-pushed
the
rustc-driver
branch
from
72b7aa2 to
b5f6eb6
Compare
Member
Author
|
Updated! |
Contributor
|
@bors r+ |
Contributor
|
📌 Commit b5f6eb6 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Dec 20, 2018
Link to `rustc_driver` crate in plugin This is in anticipation for rust-lang/rust#56987 where the `rustc_driver` crate being linked in will be required to link correctly against the compiler. In the meantime it should be harmless otherwise!
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in anticipation for rust-lang/rust#56987 where the
rustc_drivercrate being linked in will be required to link correctlyagainst the compiler. In the meantime it should be harmless otherwise!