Adjust width of page nav buttons to avoid hiding the code block clip buttons#917
Open
noritada wants to merge 1 commit intorust-lang:masterfrom
Open
Adjust width of page nav buttons to avoid hiding the code block clip buttons#917noritada wants to merge 1 commit intorust-lang:masterfrom
noritada wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
39ffa14 to
afe0519
Compare
Contributor
|
r? Kobzol |
Member
|
It seems like the navbar appears when the page width is >1080 pixels (https://github.com/rust-lang/mdBook/blob/05c6a9944696c470d62aa1b85e3613d9242755af/src/front-end/css/chrome.css#L194), and after my previous change we would ideally need to change this to something like ~1250 pixels. Can you try adding this: @media only screen and (max-width: 1250px) {
.nav-wide-wrapper { display: none; }
.nav-wrapper { display: none; }
}to |
Contributor
|
I can reproduce the issue (or what I think the reported issue is about) if I enlarge the browser window just after the navigation buttons at the bottom turn into the "sidebar" navigation. See this screencast
recording.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #894 was applied, it has been difficult to access the code clip buttons.
When I move the cursor from the lower left direction of the button, the next page navigation button covers the button before I reach it, as screenshots below shows.
(When I move the cursor from almost directly left of the button, I can reach it.)
This PR fixes that issue by reducing the width of the page navigation buttons.
I hope you will apply it if you like it.