Clarify required approvals for target promotion and demotion/removal between different target tiers#921
Merged
davidtwco merged 1 commit intorust-lang:masterfrom Aug 13, 2025
Conversation
jieyouxu
commented
Jul 23, 2025
davidtwco
reviewed
Jul 24, 2025
davidtwco
reviewed
Jul 24, 2025
Member
davidtwco
left a comment
There was a problem hiding this comment.
I assume we want something along the lines of "PR/r+" for anything related to a Tier 3 target, "MCP/FCP" for anything related to a Tier 2 target, and "RFC/FCP" for anything related to a Tier 1 target
…als between different tiers
63384d3 to
22fa860
Compare
Member
Author
|
Changed both target promotion and demotion/removal to look like this: Promoting targetsQuick overview for target promotions:
Demoting or removing targetsQuick overview for target demotions and removals:
|
Member
Author
|
@rustbot review |
davidtwco
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The promotion and demotion/removal of targets at different Target Tiers is currently too coarse. This PR tries to clarify the degree of consensus/approval required for promotions and demotions of targets between different Target Tiers.
r? @davidtwco (or @wesleywiser)
Rendered