Add Support for Testing with Output#580
Conversation
|
This can use C-u prefix, like it is implemented in https://github.com/ayrat555/cargo-mode . |
There was a problem hiding this comment.
Thanks! How about modifying rust-test to accept universal argument instead and allow it configure arbitrary argument instead ?
This would allow us to accept any arbitrary options to be passed instead of this specific usecase. You can look into rustic mode for inspiration: https://github.com/emacs-rustic/rustic?tab=readme-ov-file#test
Thank you, will definitely look into this suggestion when I get chance. |
|
Updated with the suggested change. Feel free to merge unless you want more changes, in which case let me know and I'll take a look. |
|
Hold on, I seem to have misread the suggestion, I'm going to convert to a draft while I figure this out. |
|
Sorry for the wait on this, should get to it soon :] |
|
I wanted to add an empty list of arguments that would be added to whenever you passed a I'm going to squash the commits into one then it should be ready to merge. |
This allows (optional) custom arguments to be passed the the rust-test function (press C-u before running the function).
|
|
|
@psibi Sorry for the ping, just wanted to ask if this is good to merge? Or if there's anything else you want added, let me know and I'll take a look. |
psibi
left a comment
There was a problem hiding this comment.
Thanks! Sorry about the late review, I was out on vacation. This LGTM overall. Can you add a test with an optional argument passed to it ?
|
Okay, this should be GTG now. Managed to create two tests, not sure if two is necessary but if not I can remove one. |
This PR solves the issue I raised in #579 by adding a new
rust-test-outputfunction.