Skip child modules when running RustFmtRange#478
Open
drdavella wants to merge 1 commit intorust-lang:masterfrom
Open
Skip child modules when running RustFmtRange#478drdavella wants to merge 1 commit intorust-lang:masterfrom
drdavella wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @chris-morgan (or someone else) soon. Please see the contribution instructions for more information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RustFmtRangecommand should not attempt to reformat any child modules of the module currently being formatted.Without this change, I get the following error when attempting to format a range:
While
--skip-childrenis unstable, the--file-linesoption itself is also unstable, so this seems like it shouldn't be an issue.