Improve diagnostics for const a: = expr;#100168
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 5, 2022
Merged
Conversation
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
compiler-errors
approved these changes
Aug 5, 2022
Contributor
compiler-errors
left a comment
compiler-errors
left a comment
There was a problem hiding this comment.
Thanks @WaffleLapkin
| }; | ||
| let mut err = self.struct_span_err(id.span, &format!("missing type for `{kind}` item")); | ||
|
|
||
| let colon = match colon_present { |
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
klensy
reviewed
Aug 5, 2022
| | | ||
| LL | const A = "A".$fn(); | ||
| | ^ help: provide a type for the constant: `A: usize` | ||
| | ^ help: provide a type for the constant: `: usize` |
Contributor
There was a problem hiding this comment.
Looks kinda off, IMHO: suggestion talks about type but suggest not var+type, not type, but something in between: colon+type.
Member
There was a problem hiding this comment.
I think old style is better, and also seems more consistant with other suggestions in rustc.
Contributor
There was a problem hiding this comment.
If anything this could be fixed by bumping to a verbose diagnostic, but I don't think this is necessarily a regression.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 5, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#99835 (Suggest adding/removing `ref` for binding patterns) - rust-lang#100155 (Use `node_type_opt` to skip over generics that were not expected) - rust-lang#100157 (rustdoc: use `collect()` instead of repeatedly pushing) - rust-lang#100158 (kmc-solid: Add a stub implementation of rust-lang#98246 (`File::set_times`)) - rust-lang#100166 (Remove more Clean trait implementations) - rust-lang#100168 (Improve diagnostics for `const a: = expr;`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
WaffleLapkin
deleted the
improve_diagnostics_for_missing_type_in_a_const_item
branch
Contributor
Member
Author
|
@GrigorenkoPV would you like to fix that up?.. Also, how did you stumble upon this on a >3 year old PR? |
Contributor
Sure, I'll put up a PR.
Had to update the test while working on #149738 and was trying to figure out what it was even supposed to be testing. |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Dec 11, 2025
…eLapkin Rename some issue-* tests Also fixes one incorrect issue number: rust-lang#100168 (comment)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 11, 2025
…eLapkin Rename some issue-* tests Also fixes one incorrect issue number: rust-lang#100168 (comment)
rust-timer
added a commit
that referenced
this pull request
Dec 12, 2025
Rollup merge of #149770 - GrigorenkoPV:tests/consts, r=WaffleLapkin Rename some issue-* tests Also fixes one incorrect issue number: #100168 (comment)
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 13, 2025
Rename some issue-* tests Also fixes one incorrect issue number: rust-lang/rust#100168 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a suggestion to write a type when there is a colon, but the type is not present.
I've also shrunk spans a little, so the suggestions are a little nicer.
Resolves #100146
r? @compiler-errors