change stdlib circular dependencies handling by belovdv · Pull Request #100404 · rust-lang/rust

belovdv · 2022-08-11T11:26:39Z

Remove group_start and group_end, add dependencies to symbols.o
Implements the suggestion from #85805 (comment)
r? @petrochenkov

belovdv · 2022-08-11T12:36:57Z

@rustbot author

belovdv · 2022-08-15T12:21:33Z

@rustbot ready

compiler/rustc_codegen_ssa/src/back/link.rs

compiler/rustc_codegen_ssa/src/base.rs

compiler/rustc_codegen_ssa/src/back/link.rs

compiler/rustc_codegen_ssa/src/lib.rs

petrochenkov · 2022-08-16T15:00:30Z

@bors try @rust-timer queue

rust-timer · 2022-08-16T15:00:32Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-08-16T15:00:39Z

⌛ Trying commit 819daad38be437c3bb16a8b80bb01fb82cd367cc with merge b069a434200d6e5f6a8497bd62344966d1c24d3c...

bors · 2022-09-06T13:46:06Z

⌛ Testing commit c34047c with merge aed0a7b6c7bb973505567f10de217731597d1537...

bors · 2022-09-06T14:33:20Z

💔 Test failed - checks-actions

rust-log-analyzer · 2022-09-06T15:06:32Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

petrochenkov · 2022-09-06T17:18:24Z

No output from the builder, weird.
@bors retry

bors · 2022-09-06T22:06:57Z

⌛ Testing commit c34047c with merge 699bfa8...

bors · 2022-09-07T00:35:47Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 699bfa8 to master...

rust-timer · 2022-09-07T01:51:08Z

Finished benchmarking commit (699bfa8): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.2%	[1.1%, 1.3%]	2
Regressions ❌ (secondary)	3.4%	[3.0%, 3.9%]	6
Improvements ✅ (primary)	-0.8%	[-0.9%, -0.7%]	6
Improvements ✅ (secondary)	-1.0%	[-1.0%, -1.0%]	1
All ❌✅ (primary)	-0.3%	[-0.9%, 1.3%]	8

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.8%	[4.8%, 4.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.8%	[2.8%, 2.8%]	1

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

nnethercote · 2022-09-07T02:01:50Z

The html5ever and keccak benchmarks have been bimodal and thus misleading lately, so those regressions probably aren't real. The cranelift-codegen ones I'm not sure about, they may or may not be real.

pnkfelix · 2022-09-14T04:05:14Z

I think subsequent evidence from past week shows that cranelift-codegen is also behaving in a bimodal manner.

@rustbot label: perf-regression-triaged

linker: Fix weak lang item linking with combination windows-gnu + LLD + LTO In rust-lang#100404 this logic was originally disabled for MSVC due to issues with LTO, but the same issues appear on windows-gnu with LLD because that LLD uses the same underlying logic as MSVC LLD, just with re-syntaxed command line options. So this PR just disables it for LTO builds in general.

linker: Fix weak lang item linking with combination windows-gnu + LLD + LTO In rust-lang/rust#100404 this logic was originally disabled for MSVC due to issues with LTO, but the same issues appear on windows-gnu with LLD because that LLD uses the same underlying logic as MSVC LLD, just with re-syntaxed command line options. So this PR just disables it for LTO builds in general.

rust-highfive assigned petrochenkov Aug 11, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 11, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 11, 2022

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2022

belovdv closed this Aug 15, 2022

belovdv force-pushed the linker_group branch from 8a346e0 to f03ce30 Compare August 15, 2022 10:13

belovdv reopened this Aug 15, 2022

belovdv force-pushed the linker_group branch from e03364b to a1140ae Compare August 15, 2022 11:38

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 15, 2022

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2022

petrochenkov reviewed Aug 15, 2022

View reviewed changes