Closed
Conversation
…ce used to create an `IntoIter` from its parts
(suggested in the review of the previous attempt to add `ArrayChunks`)
As explained in the review of the previous attempt to add `ArrayChunks`, adapters that shrink the length can't implement `TrustedLen`.
It doesn't seem to be used at all.
The "fallback" naming pre-dates introduction of `-Clink-self-contained`
…-arg-label, r=estebank Only point out a single function parameter if we have a single arg incompatibility Fixes rust-lang#99635
Add `Iterator::array_chunks` (take N+1) A revival of rust-lang#92393. r? `@Mark-Simulacrum` cc `@rossmacarthur` `@scottmcm` `@the8472` I've tried to address most of the review comments on the previous attempt. The only thing I didn't address is `try_fold` implementation, I've left the "custom" one for now, not sure what exactly should it use.
rustc_target: Update some old naming around self contained linking The "fallback" naming pre-dates introduction of `-Clink-self-contained`. Noticed when reviewing rust-lang#99500. This PR doesn't break any json target spec, but supporting per-linker-flavor startup objects needed by rust-lang#99500 will break them, so maybe next time I'll remove the compatibility names.
…=GuillaumeGomez Rustdoc-Json: Add `Path` type for traits. Avoids using `Type` for trait fields, as a trait must always be a path, and not any other kind of type. `@rustbot` modify labels: +A-rustdoc-json +T-rustdoc Closes rust-lang#100106
Suggest the path separator when a dot is used on a trait Fixes rust-lang#100365. `@rustbot` label A-diagnostics r? diagnostics
…gillot Fix HIR pretty printing of let else Fixes rust-lang#100373 Fixes rust-lang#99318 Fixes rust-lang#99319
…lan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@Dylan-DPC`
rustbot
added
the
T-compiler
rustbot
added
T-libs
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 5cdb1e3 with merge d5eff2e048313be256218f1bc4ae1ef661759cef... |
Collaborator
|
💥 Test timed out |
bors
added
S-waiting-on-review
Member
|
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 5cdb1e3 with merge a04d77f3d1d1568d61c63ce9a9c629e82de650d1... |
Collaborator
Member
|
@bors retry |
Collaborator
|
⌛ Testing commit 5cdb1e3 with merge 16359f6694a9780edd2edf6a2b62dd907a5312b8... |
Collaborator
Collaborator
|
💥 Test timed out |
bors
added
S-waiting-on-review
Collaborator
Collaborator
|
☔ The latest upstream changes (presumably #100510) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Iterator::array_chunks(take N+1) #100026 (AddIterator::array_chunks(take N+1))Pathtype for traits. #100335 (Rustdoc-Json: AddPathtype for traits.)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup