Rollup of 6 pull requests

[Dylan-DPC]

Successful merges:

• Delay a span bug if we see ty/const generic params during writeback #99582 (Delay a span bug if we see ty/const generic params during writeback)
• orphan check: rationalize our handling of constants #99861 (orphan check: rationalize our handling of constants)
• Add Iterator::array_chunks (take N+1) #100026 (Add Iterator::array_chunks (take N+1))
• Suggest removing let if const let or let const is used #100115 (Suggest removing let if const let or let const is used)
• rustc_target: Update some old naming around self contained linking #100126 (rustc_target: Update some old naming around self contained linking)
• assert_{inhabited,zero_valid,uninit_valid} intrinsics are safe #100487 (assert_{inhabited,zero_valid,uninit_valid} intrinsics are safe)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[Dylan-DPC]

@bors r+ rollup=never p=5

[bors]

📌 Commit 9de9786 has been approved by Dylan-DPC

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9de9786 with merge 4c56655...

[bors]

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 4c56655 to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#100487	fbc9a0059b422ef77feb156e99a3538029a8f6e2
#100126	08602b58216a6218a95c062b9e0c6e72a43868e4
#100115	3bd15868bf63fac3bc21576c985f4033081523f1
#100026	a715de5a993ff2b0336623c006b4ef264c8b4e68
#99861	0df69d7f65faecd418e58cc8b385481650954d1a
#99582	17c754e6d2f938935c01ff56be104e010ecd44ba

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (4c56655): comparison url.

Instruction count

• Primary benchmarks: ❌ relevant regression found
• Secondary benchmarks: ❌ relevant regression found

	mean1	max	count2
Regressions ❌ (primary)	0.2%	0.2%	1
Regressions ❌ (secondary)	0.4%	0.4%	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	0.2%	1

Max RSS (memory usage)

Results

• Primary benchmarks: ❌ relevant regression found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions ❌ (primary)	0.9%	0.9%	1
Regressions ❌ (secondary)	2.8%	3.2%	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	-3.8%	4
All ❌✅ (primary)	0.9%	0.9%	1

Cycles

Results

• Primary benchmarks: ✅ relevant improvement found
• Secondary benchmarks: no relevant changes found

	mean1	max	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	-2.8%	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	-2.8%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³