Merged
Conversation
Recover from mutable variable declaration where `mut` is placed before `let`
In rust-lang#100513 it was shown that the drop behavior of let_chains is not correct currently. Since drop behavior is something pretty subtle, this adds explicit tests for the drop behavior of `if`, `if let` and `match` to make sure that it does not regress in the future. The `println!`s were left in to make debugging easier in case something goes wrong, but they are not required for the test.
Fix HorizonOS regression in FileTimes The changes in rust-lang#98246 caused a regression for multiple Newlib-based systems. This is just a fix including HorizonOS to the list of targets which require a workaround. ``@AzureMarker`` ``@ian-h-chamberlain`` r? ``@nagisa``
Recover from mutable variable declaration where `mut` is placed before `let` Closes rust-lang#100197
Add Duration rounding change to release note one of possible fix of rust-lang#100480 fixes rust-lang#100480
… r=Dylan-DPC [rustdoc] remove Clean trait Follow-up of rust-lang#99638. This is (finally!) the last part. r? `@Dylan-DPC`
…ild-structs, r=Mark-Simulacrum Impl `Debug` for some structs of rustbuild A small patch to impl `Debug` for some structs of rustbuild to make debugging easier. (I was trying to impl `Debug` for the `Config` struct, but found to have a bit more things to do. So gave up for now.)
Add tests for the drop behavior of some control flow constructs In rust-lang#100513 it was shown that the drop behaviour of let_chains is not correct currently. Since drop behaviour is something pretty subtle, this adds explicit tests for the drop behavior of `if`, `if let` and `match` to make sure that it does not regress in the future. The `println!`s were left in to make debugging easier in case something goes wrong, but they are not required for the test.
rustbot
added
T-bootstrap
Member
Author
|
@bors r+ rollup=never p=6 |
Collaborator
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (b8c0a01): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
mutis placed beforelet#100253 (Recover from mutable variable declaration wheremutis placed beforelet)Debugfor some structs of rustbuild #100524 (ImplDebugfor some structs of rustbuild)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup