Make `ReentrantMutex` movable and `const` by joboet · Pull Request #100576 · rust-lang/rust

joboet · 2022-08-15T11:06:49Z

As MovableMutex is now const, it can be used to simplify the implementation and interface of the internal reentrant mutex type. Consequently, the standard error stream does not need to be wrapped in OnceLock and OnceLock::get_or_init_pin() can be removed.

rustbot · 2022-08-15T11:06:52Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-08-15T11:06:52Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

library/std/src/io/stdio.rs

Mark-Simulacrum · 2022-08-20T16:03:09Z

cc @m-ou-se in case you have opinions, but I don't see anything that particularly needs your insight in this PR.

joboet · 2022-08-20T16:59:35Z

@rustbot ready

library/std/src/io/stdio.rs

joboet · 2022-08-20T17:34:11Z

@rustbot ready

Mark-Simulacrum · 2022-08-20T20:44:33Z

@bors r+ rollup=iffy

bors · 2022-08-20T20:44:34Z

📌 Commit 9d222e9 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…rk-Simulacrum Make `ReentrantMutex` movable and `const` As `MovableMutex` is now `const`, it can be used to simplify the implementation and interface of the internal reentrant mutex type. Consequently, the standard output and error streams do not need to be wrapped in `OnceLock` and `OnceLock::get_or_init_pin()` can be removed. Moving the initialization of the `Stdout` buffer to `StdoutLock` means that there is only one synchronization primitive required, at the cost of probably two instructions for every read/write.

library/std/src/io/stdio.rs

…tialization

joboet · 2022-09-03T12:07:03Z

@rustbot ready

Mark-Simulacrum · 2022-09-04T14:42:47Z

@bors r+

bors · 2022-09-04T14:42:48Z

📌 Commit 8c37fdf has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2022-09-04T15:29:01Z

⌛ Testing commit 8c37fdf with merge 09fb0bc6ecef62201d7c662db24b984d03245ac6...

bors · 2022-09-04T18:09:57Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 09fb0bc6ecef62201d7c662db24b984d03245ac6 to master...

bors · 2022-09-04T18:10:00Z

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

rust-timer · 2022-09-04T20:32:53Z

Finished benchmarking commit (09fb0bc6ecef62201d7c662db24b984d03245ac6): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.7%, -0.6%]	5
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[2.3%, 3.8%]	3
Improvements ✅ (primary)	-3.4%	[-3.4%, -3.4%]	1
Improvements ✅ (secondary)	-2.1%	[-2.6%, -1.6%]	2
All ❌✅ (primary)	-3.4%	[-3.4%, -3.4%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.7%	[1.6%, 3.8%]	2
Regressions ❌ (secondary)	6.3%	[4.3%, 8.4%]	2
Improvements ✅ (primary)	-3.1%	[-3.1%, -3.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[-3.1%, 3.8%]	3

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

Mark-Simulacrum · 2022-09-04T20:48:43Z

@bors r- retry r+

bors · 2022-09-04T20:48:47Z

📌 Commit 8c37fdf has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2022-09-04T22:54:02Z

⌛ Testing commit 8c37fdf with merge e7cdd4c...

bors · 2022-09-05T01:34:56Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing e7cdd4c to master...

rust-timer · 2022-09-05T04:10:42Z

Finished benchmarking commit (e7cdd4c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.8%, -0.6%]	5
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.3%	[3.3%, 3.3%]	1
Improvements ✅ (primary)	-1.9%	[-1.9%, -1.9%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.9%	[-1.9%, -1.9%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

rust-highfive assigned Mark-Simulacrum Aug 15, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 15, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2022

This comment has been minimized.

Sign in to view

joboet force-pushed the movable_const_remutex branch from b6004c5 to 8eacc7d Compare August 15, 2022 12:02

joboet mentioned this pull request Aug 15, 2022

Do not wrap platform locks in sys_common #100505

Closed

Mark-Simulacrum reviewed Aug 20, 2022

View reviewed changes

library/std/src/io/stdio.rs Outdated Show resolved Hide resolved

library/std/src/io/stdio.rs Outdated Show resolved Hide resolved

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2022

joboet force-pushed the movable_const_remutex branch from 8eacc7d to a30d3a9 Compare August 20, 2022 16:59

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 20, 2022

Mark-Simulacrum reviewed Aug 20, 2022

View reviewed changes

library/std/src/io/stdio.rs Outdated Show resolved Hide resolved

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2022

joboet force-pushed the movable_const_remutex branch from a30d3a9 to 9d222e9 Compare August 20, 2022 17:33

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 20, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2022

matthiaskrgr mentioned this pull request Aug 28, 2022

Rollup of 12 pull requests #101132

Closed

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 28, 2022

m-ou-se reviewed Aug 30, 2022

View reviewed changes

library/std/src/io/stdio.rs Outdated Show resolved Hide resolved

std: make ReentrantMutex movable and const; simplify Stdout ini…

8c37fdf

…tialization

joboet force-pushed the movable_const_remutex branch from 9d222e9 to 8c37fdf Compare September 3, 2022 12:05

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 4, 2022

bors merged commit e7cdd4c into rust-lang:master Sep 5, 2022

rustbot added this to the 1.65.0 milestone Sep 5, 2022

bors mentioned this pull request Sep 5, 2022

Fix cleanup for uninitialized stdout #101404

Merged

joboet deleted the movable_const_remutex branch September 11, 2022 10:31

Uh oh!

Conversation

joboet commented Aug 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 15, 2022

Uh oh!

rust-highfive commented Aug 15, 2022

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Mark-Simulacrum commented Aug 20, 2022

Uh oh!

joboet commented Aug 20, 2022

Uh oh!

Uh oh!

joboet commented Aug 20, 2022

Uh oh!

Mark-Simulacrum commented Aug 20, 2022

Uh oh!

bors commented Aug 20, 2022

Uh oh!

Uh oh!

joboet commented Sep 3, 2022

Uh oh!

Mark-Simulacrum commented Sep 4, 2022

Uh oh!

bors commented Sep 4, 2022

Uh oh!

bors commented Sep 4, 2022

Uh oh!

bors commented Sep 4, 2022

Uh oh!

bors commented Sep 4, 2022

Uh oh!

rust-timer commented Sep 4, 2022

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Mark-Simulacrum commented Sep 4, 2022

Uh oh!

bors commented Sep 4, 2022

Uh oh!

bors commented Sep 4, 2022

Uh oh!

bors commented Sep 5, 2022

Uh oh!

rust-timer commented Sep 5, 2022

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

joboet commented Aug 15, 2022 •

edited

Loading