Merged
Conversation
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
…tem, r=cjgillot Remove opt_remap_env_constness from rustc_query_impl 1st task off rust-lang#96524. r? `@cjgillot`
…thomcc Add `IpDisplayBuffer` helper struct. This removes the dependency on `std::io::Write` for implementing `Display`, allowing it to be moved to `core` as proposed in rust-lang/rfcs#2832.
…er-errors Use `merged_ty` method instead of rewriting it every time `merged_ty` [source code](https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_typeck/check/coercion.rs.html#1331-1333) is quite literally the same, so instead of rewriting it, makes more sense to use the method instead. r? `@compiler-errors`
…f, r=GuillaumeGomez rustdoc JSON: Fix ICE with `pub extern crate self as <self_crate_name>` Closes rust-lang#100531 r? `@GuillaumeGomez` `@rustbot` labels +A-rustdoc-json +T-rustdoc
Member
Author
|
@bors r+ rollup=never p=4 |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (86c6ebe): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
IpDisplayBufferhelper struct. #100625 (AddIpDisplayBufferhelper struct.)merged_tymethod instead of rewriting it every time #100629 (Usemerged_tymethod instead of rewriting it every time)pub extern crate self as <self_crate_name>#100630 (rustdoc JSON: Fix ICE withpub extern crate self as <self_crate_name>)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup