Conversation
This comment has been minimized.
This comment has been minimized.
|
FYI, I don't have r+ privileges, so can't approve this PR. r? @CraftSpider |
|
I know, but if it looks good to you, I can approve for you, so it's fine. ;) |
329dca9 to
6f2b5e4
Compare
|
Applied your suggestions (and rebased on master to fix CI). |
6f2b5e4 to
c71550e
Compare
|
Applied suggestions bis repetita. :) |
This comment has been minimized.
This comment has been minimized.
c71550e to
12102f0
Compare
|
☔ The latest upstream changes (presumably #100677) made this pull request unmergeable. Please resolve the merge conflicts. |
12102f0 to
d3d9e22
Compare
|
@bors: r=aDotInTheVoid rollup=never |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (7e3e8a8): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Fixes #100588.
r? @aDotInTheVoid