Split out async_fn_in_trait into a separate feature by ComputerDruid · Pull Request #100734 · rust-lang/rust

ComputerDruid · 2022-08-18T23:30:17Z

PR #101224 added support for async fn in trait desuraging behind the return_position_impl_trait_in_trait feature.

Split this out so that it's behind its own feature gate, since async fn in trait doesn't need to follow the same stabilization schedule.

rust-highfive · 2022-08-18T23:30:20Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon.

Please see the contribution instructions for more information.

compiler/rustc_feature/src/active.rs

bors · 2022-08-22T12:05:53Z

☔ The latest upstream changes (presumably #100868) made this pull request unmergeable. Please resolve the merge conflicts.

nagisa · 2022-08-29T10:10:29Z

I’m not quite following what the value is behind making this change in isolation. Having a feature that simply makes certain constructs into an ICE doesn’t really help with testing the feature in any way or form, really. It also seems like a straightforward enough change that it could be introduced alongside other changes necessary to implement at least barebones support for the feature.

tmandry · 2022-08-30T01:48:09Z

I'm working with @ComputerDruid on this and I think it's an okay place to start! In total isolation I agree landing a change like this wouldn't make sense, but an actual implementation is being worked on right now and there are a couple threads happening in parallel, so let's start by landing just the feature gate.

@bors r+ rollup

bors · 2022-08-30T01:48:11Z

📌 Commit 636cabc has been approved by tmandry

It is now in the queue for this repository.

add incomplete feature async_fn_in_trait Doesn't do much yet, just disables the check preventing the use of the syntax. Attempting to use it just results in ICE 🧊.

compiler-errors · 2022-08-30T05:42:11Z

@bors r- please fix the tidy check on this, see #101182 (comment)

nagisa · 2022-09-03T18:37:53Z

r? @tmandry

ComputerDruid · 2022-09-07T23:49:48Z

@bors r- please fix the tidy check on this, see #101182 (comment)

Done.

tmandry · 2022-09-08T23:31:01Z

@bors r+ rollup

bors · 2022-09-08T23:31:03Z

📌 Commit d468cadeedd950c711ea70e02f19d21be993d386 has been approved by tmandry

It is now in the queue for this repository.

compiler-errors · 2022-09-09T00:15:18Z

@tmandry, I added a return_position_impl_trait_in_trait feature in #101224 (which probably will land by tonight). Basically in the same vein as #100734 (comment) "It also seems like a straightforward enough change that it could be introduced alongside other changes necessary to implement at least barebones support for the feature" (I needed to add the gate in order to actually impl anything, lol).

Do you think we need another feature gate? I'm fine if this PR is reworked to gate AFIT desugaring behind a different feature gate I guess, but I don' t personally see a benefit. Alternatively, this PR could be reworked to rename the gate from return_position_impl_trait_in_trait to async_fn_in_trait, if there is a concern about length of the feature name.

compiler/rustc_ast_lowering/src/lib.rs

compiler-errors

Can you address these two comments then also add a test that checks async fn foo() -> impl Trait requires both feature gates?

ComputerDruid · 2022-09-09T23:09:29Z

I "rebased" on #101224 . I still want to fix up a few things before this is merged:

update return_position_impl_trait_in_trait to use a different tracking issue
check some of the error messages I blessed to see if they should turn into actual test cases of the feature.

ComputerDruid · 2022-09-09T23:47:45Z

Can you address these two comments then also add a test that checks async fn foo() -> impl Trait requires both feature gates?

I added the test, but it doesn't seem to require both features right now. Will need to debug that

ComputerDruid · 2022-09-15T21:07:02Z

Can you address these two comments then also add a test that checks async fn foo() -> impl Trait requires both feature gates?

I added the test, but it doesn't seem to require both features right now. Will need to debug that

Should be fixed now.

bors · 2022-09-20T22:14:31Z

☔ The latest upstream changes (presumably #102061) made this pull request unmergeable. Please resolve the merge conflicts.

compiler-errors · 2022-09-21T16:49:03Z

@ComputerDruid sorry, I got sick over the weekend and forgot to r+. Please rebase this and then I can approve shortly.

PR rust-lang#101224 added support for async fn in trait desuraging behind the return_position_impl_trait_in_trait feature. Split this out so that it's behind its own feature gate, since async fn in trait doesn't need to follow the same stabilization schedule.

ComputerDruid · 2022-09-22T02:28:41Z

rebased and squashed into one commit

compiler-errors · 2022-09-22T15:16:48Z

@bors r+

bors · 2022-09-22T15:16:50Z

📌 Commit d0a0749 has been approved by compiler-errors

It is now in the queue for this repository.

…iler-errors Split out async_fn_in_trait into a separate feature PR rust-lang#101224 added support for async fn in trait desuraging behind the `return_position_impl_trait_in_trait` feature. Split this out so that it's behind its own feature gate, since async fn in trait doesn't need to follow the same stabilization schedule.

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#100734 (Split out async_fn_in_trait into a separate feature) - rust-lang#101664 (Note if mismatched types have a similar name) - rust-lang#101815 (Migrated the rustc_passes annotation without effect diagnostic infrastructure) - rust-lang#102042 (Distribute rust-docs-json via rustup.) - rust-lang#102066 (rustdoc: remove unnecessary `max-width` on headers) - rust-lang#102095 (Deduplicate two functions that would soon have been three) - rust-lang#102104 (Set 'exec-env:RUST_BACKTRACE=0' in const-eval-select tests) - rust-lang#102112 (Allow full relro on powerpc64-unknown-linux-gnu) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned nagisa Aug 18, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 18, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2022

ComputerDruid commented Aug 18, 2022

View reviewed changes

compiler/rustc_feature/src/active.rs Outdated Show resolved Hide resolved

ComputerDruid force-pushed the afit_feature branch 2 times, most recently from bca9a2a to 636cabc Compare August 23, 2022 00:14

ComputerDruid marked this pull request as ready for review August 23, 2022 00:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2022

matthiaskrgr mentioned this pull request Aug 30, 2022

Rollup of 8 pull requests #101182

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 30, 2022

rust-highfive assigned tmandry and unassigned nagisa Sep 3, 2022

ComputerDruid force-pushed the afit_feature branch 2 times, most recently from ceb5b20 to d468cad Compare September 7, 2022 23:48

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 8, 2022

compiler-errors reviewed Sep 9, 2022

View reviewed changes

compiler/rustc_ast_lowering/src/lib.rs Outdated Show resolved Hide resolved

compiler-errors reviewed Sep 9, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

ComputerDruid force-pushed the afit_feature branch from 0845ffe to eca8dfb Compare September 22, 2022 02:25

ComputerDruid force-pushed the afit_feature branch from eca8dfb to d0a0749 Compare September 22, 2022 02:26

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 22, 2022

matthiaskrgr mentioned this pull request Sep 22, 2022

Rollup of 7 pull requests #102149

Closed

matthiaskrgr mentioned this pull request Sep 22, 2022

Rollup of 9 pull requests #102153

Closed

matthiaskrgr mentioned this pull request Sep 23, 2022

Rollup of 8 pull requests #102165

Merged

bors merged commit 5d7937d into rust-lang:master Sep 23, 2022

rustbot added this to the 1.66.0 milestone Sep 23, 2022

matthiaskrgr mentioned this pull request Sep 23, 2022

Rollup of 10 pull requests #102191

Closed

ComputerDruid deleted the afit_feature branch September 23, 2022 21:00

tmandry mentioned this pull request Nov 1, 2022

Tracking Issue for async_fn_in_trait, return_position_impl_trait_in_trait #91611

Closed

7 tasks

Uh oh!

Conversation

ComputerDruid commented Aug 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Aug 18, 2022

Uh oh!

Uh oh!

bors commented Aug 22, 2022

Uh oh!

nagisa commented Aug 29, 2022

Uh oh!

tmandry commented Aug 30, 2022

Uh oh!

bors commented Aug 30, 2022

Uh oh!

compiler-errors commented Aug 30, 2022

Uh oh!

nagisa commented Sep 3, 2022

Uh oh!

ComputerDruid commented Sep 7, 2022

Uh oh!

tmandry commented Sep 8, 2022

Uh oh!

bors commented Sep 8, 2022

Uh oh!

compiler-errors commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

compiler-errors left a comment

Choose a reason for hiding this comment

Uh oh!

ComputerDruid commented Sep 9, 2022

Uh oh!

ComputerDruid commented Sep 9, 2022

Uh oh!

This comment has been minimized.

ComputerDruid commented Sep 15, 2022

Uh oh!

bors commented Sep 20, 2022

Uh oh!

compiler-errors commented Sep 21, 2022

Uh oh!

ComputerDruid commented Sep 22, 2022

Uh oh!

compiler-errors commented Sep 22, 2022

Uh oh!

bors commented Sep 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ComputerDruid commented Aug 18, 2022 •

edited

Loading

compiler-errors commented Sep 9, 2022 •

edited

Loading