Rollup of 9 pull requests by Dylan-DPC · Pull Request #100740 · rust-lang/rust

Dylan-DPC · 2022-08-19T06:56:49Z

Successful merges:

Do not allow Drop impl on foreign fundamental types #99576 (Do not allow Drop impl on foreign fundamental types)
never consider unsafe blocks unused if they would be required with deny(unsafe_op_in_unsafe_fn) #100081 (never consider unsafe blocks unused if they would be required with deny(unsafe_op_in_unsafe_fn))
make NOP dyn casts not require anything about the vtable #100208 (make NOP dyn casts not require anything about the vtable)
Cleanup rustdoc themes #100494 (Cleanup rustdoc themes)
Only check the DefId for the recursion check in MIR inliner. #100522 (Only check the DefId for the recursion check in MIR inliner.)
Manually implement Debug for ImportKind. #100592 (Manually implement Debug for ImportKind.)
Don't fix builtin index when Where clause is found #100598 (Don't fix builtin index when Where clause is found)
Add diagnostics lints to rustc_type_ir module #100721 (Add diagnostics lints to rustc_type_ir module)
rustdoc: count deref and non-deref as same set of used methods #100731 (rustdoc: count deref and non-deref as same set of used methods)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

…safe_op_in_unsafe_fn

Co-authored-by: Léo Lanteri Thauvin <leseulartichaut@gmail.com>

Module is completed because it doesn’t have any diagnostics

…-drop-is-bad, r=TaKO8Ki Do not allow `Drop` impl on foreign fundamental types `Drop` should not be implemented on `Pin<T>` even if `T` is local. This does not trigger regular orphan rules is because `Pin` is `#[fundamental]`... but we don't allow specialized `Drop` impls anyways, so these rules are not sufficient to prevent this impl on stable. Let's just choose even stricter rules, since we shouldn't be implementing `Drop` on a foreign ADT ever. Fixes rust-lang#99575

…n, r=jackh726 never consider unsafe blocks unused if they would be required with deny(unsafe_op_in_unsafe_fn) Judging from rust-lang#71668 (comment) the consensus nowadays seems to be that we should never consider an unsafe block unused if it was required with `deny(unsafe_op_in_unsafe_fn)`, no matter whether that lint is actually enabled or not. So let's adjust rustc accordingly. The first commit does the change, the 2nd does some cleanup.

…enkov make NOP dyn casts not require anything about the vtable As suggested [on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/144729-t-types/topic/dyn-upcasting.20stabilization/near/292151439). This matches what the codegen backends already do, and what Miri did do until rust-lang#99420 when I made it super extra paranoid.

Cleanup rustdoc themes This PR continues our work to simplify the rustdoc themes by relying more on CSS variables. Interestingly enough, this time it allowed me to realize that we were having a lot of different colors for borders even though the difference is unnoticeable. I used this opportunity to unify them. The live demo is [here](https://rustdoc.crud.net/imperio/cleanup-themes/std/index.html). r? `@jsha`

…ion, r=tmiasko Only check the `DefId` for the recursion check in MIR inliner. The current history check compares `Instance`s, so it cannot detect cases of polymorphic recursion where `Substs` change. This PR makes it so we only compare `DefId`s, ignoring any change in `Substs`. According to rust-lang#100522 (comment), in practice only very few inlining decisions change. Fixes rust-lang#100476

Manually implement Debug for ImportKind. This avoids crashing due to an infinite loop when running with `RUSTC_LOG=rustc_resolve`.

Don't fix builtin index when Where clause is found Where clause shadows blanket impl for `Index` which causes normalization to not occur, which causes ICE to happen when we typeck. r? `@compiler-errors` Fixes rust-lang#91633

…pe-ir, r=compiler-errors Add diagnostics lints to `rustc_type_ir` module Module is complete. It doesn’t have any diagnostics.

…1, r=jsha rustdoc: count deref and non-deref as same set of used methods Fixes rust-lang#100679

Dylan-DPC · 2022-08-19T06:57:04Z

@bors r+ rollup=never p=5

bors · 2022-08-19T06:57:06Z

📌 Commit ecd2885 has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2022-08-19T11:06:12Z

⌛ Testing commit ecd2885 with merge 76bd100bd3b09a5592c1b9bf3b1d70d386b8617f...

bors · 2022-08-19T15:21:12Z

💥 Test timed out

rust-log-analyzer · 2022-08-19T15:34:13Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Dylan-DPC · 2022-08-19T15:50:54Z

@bors retry

bors · 2022-08-19T18:45:45Z

⌛ Testing commit ecd2885 with merge e1b28cd...

bors · 2022-08-19T22:22:43Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing e1b28cd to master...

rust-highfive · 2022-08-19T22:23:08Z

📣 Toolstate changed by #100740!

Tested on commit e1b28cd.
Direct link to PR: #100740

💔 miri on windows: test-pass → test-fail (cc @RalfJung @oli-obk).
💔 miri on linux: test-pass → test-fail (cc @RalfJung @oli-obk).

@RalfJung

Tested on commit rust-lang/rust@e1b28cd. Direct link to PR: <rust-lang/rust#100740> 💔 miri on windows: test-pass → test-fail (cc @RalfJung @oli-obk). 💔 miri on linux: test-pass → test-fail (cc @RalfJung @oli-obk).

rust-timer · 2022-08-19T22:25:32Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#100731	1bfe103ad9665f9774d2eb18e4e90712d7a9ff61
#100721	2a8dba7d494eefb47cc4494f8481398cfc3eafef
#100598	2351cb3d3a494f14f9c21eee8d5e2867f739e4ba
#100592	e37143a278e6e96c840e1a4635dbf1646edbb356
#100522	7f6f628282e303b5877a0af5dc788a5040a36b15
#100494	7e7e2ef2cff1536bc4390aae0d96d92ef6c419e9
#100208	0770a06547c13883b59be73501e932af2d1ce366
#100081	5a573973559cfbd0378535979b513e52aa8ca26e
#99576	7cfb8d2ea49e3aba0c83a5c175675cea252c4567

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-08-19T23:37:58Z

Finished benchmarking commit (e1b28cd): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	2.5%	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	-2.8%	1
All ❌✅ (primary)	-	-	0

Cycles

Results

Primary benchmarks: mixed results
Secondary benchmarks: no relevant changes found

	mean¹	max	count²
Regressions ❌ (primary)	3.8%	3.8%	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.2%	-4.2%	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.2%	-4.2%	2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

RalfJung and others added 24 commits August 2, 2022 17:09

never consider unsafe blocks unused if they would be required with un…

ee3fc9d

…safe_op_in_unsafe_fn

remove some unused code and types

3e44ca9

update comment

35a35d8

Co-authored-by: Léo Lanteri Thauvin <leseulartichaut@gmail.com>

add link to discussion

86e2ca3

make NOP dyn casts not require anything about the vtable

3c8563a

Manually implement Debug for ImportKind.

4a5c46f

Update compiler/rustc_resolve/src/imports.rs

611221d

Do not allow Drop impl on foreign fundamental types

fd934c9

pass when where clause found

7b45718

Ignore substs when checking inlining history.

86645c9

Simplify rustdoc themes by relying more on CSS variables

2d968a1

Update existing rustdoc-gui tests and add a new one

9898793

Remove unused CSS rule

09396fc

ADD - diagnostic lints to type_ir

05ed13b

Module is completed because it doesn’t have any diagnostics

rustdoc: count deref and non-deref as same set of used methods

748c606

Rollup merge of rust-lang#100592 - cjgillot:debug-import-kind, r=TaKO8Ki

769ad70

Manually implement Debug for ImportKind. This avoids crashing due to an infinite loop when running with `RUSTC_LOG=rustc_resolve`.

Rollup merge of rust-lang#100721 - JhonnyBillM:enable-diag-lint-in-ty…

30e65ce

…pe-ir, r=compiler-errors Add diagnostics lints to `rustc_type_ir` module Module is complete. It doesn’t have any diagnostics.

Rollup merge of rust-lang#100731 - notriddle:notriddle/deref-methods-…

ecd2885

…1, r=jsha rustdoc: count deref and non-deref as same set of used methods Fixes rust-lang#100679

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 19, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 19, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 19, 2022

bors merged commit e1b28cd into rust-lang:master Aug 19, 2022

rustbot added this to the 1.65.0 milestone Aug 19, 2022

rust-highfive mentioned this pull request Aug 19, 2022

miri no longer builds after rust-lang/rust#100740 #100779

Closed

This was referenced Aug 19, 2022

Port improved unused_unsafe check to -Zthir_unsafeck #99379

Closed

Add MVP suggestion for unsafe_op_in_unsafe_fn #99827

Closed

interpret: remove support for uninitialized scalars #100043

Merged

Rollup of 7 pull requests #100395

Merged

RalfJung mentioned this pull request Aug 21, 2022

ICE: encountered overly generic constant rust-lang/miri#2499

Closed

davidtwco removed the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Oct 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 9 pull requests#100740

Rollup of 9 pull requests#100740
bors merged 24 commits intorust-lang:masterfrom
Dylan-DPC:rollup-0td6yq4

Dylan-DPC commented Aug 19, 2022

Uh oh!

Dylan-DPC commented Aug 19, 2022

Uh oh!

bors commented Aug 19, 2022

Uh oh!

bors commented Aug 19, 2022

Uh oh!

bors commented Aug 19, 2022

Uh oh!

rust-log-analyzer commented Aug 19, 2022

Uh oh!

Dylan-DPC commented Aug 19, 2022

Uh oh!

bors commented Aug 19, 2022

Uh oh!

bors commented Aug 19, 2022

Uh oh!

rust-highfive commented Aug 19, 2022

Uh oh!

rust-timer commented Aug 19, 2022

Uh oh!

rust-timer commented Aug 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Uh oh!

Conversation

Dylan-DPC commented Aug 19, 2022

Uh oh!

Dylan-DPC commented Aug 19, 2022

Uh oh!

bors commented Aug 19, 2022

Uh oh!

bors commented Aug 19, 2022

Uh oh!

bors commented Aug 19, 2022

Uh oh!

rust-log-analyzer commented Aug 19, 2022

Uh oh!

Dylan-DPC commented Aug 19, 2022

Uh oh!

bors commented Aug 19, 2022

Uh oh!

bors commented Aug 19, 2022

Uh oh!

rust-highfive commented Aug 19, 2022

Uh oh!

rust-timer commented Aug 19, 2022

Uh oh!

rust-timer commented Aug 19, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants