Rollup of 10 pull requests by matthiaskrgr · Pull Request #100793 · rust-lang/rust

matthiaskrgr · 2022-08-20T05:09:07Z

Successful merges:

Mention as_mut alongside as_ref in borrowck error message #100186 (Mention as_mut alongside as_ref in borrowck error message)
Mitigate stale data reads on SGX platform #100383 (Mitigate stale data reads on SGX platform)
suggest once_cell::Lazy for non-const statics #100507 (suggest once_cell::Lazy for non-const statics)
Suggest the right help message for as_ref #100617 (Suggest the right help message for as_ref)
Migrate "invalid variable declaration" errors to SessionDiagnostic #100667 (Migrate "invalid variable declaration" errors to SessionDiagnostic)
Migrate typeck's used expected symbol diagnostic to SessionDiagnostic #100709 (Migrate typeck's used expected symbol diagnostic to SessionDiagnostic)
Add the diagnostic translation lints to crates that don't emit them #100723 (Add the diagnostic translation lints to crates that don't emit them)
Avoid zeroing a 1kb stack buffer on every call to std::sys::windows::fill_utf16_buf #100729 (Avoid zeroing a 1kb stack buffer on every call to std::sys::windows::fill_utf16_buf)
improved diagnostic for function defined with def, fun, func, or function instead of fn #100750 (improved diagnostic for function defined with def, fun, func, or function instead of fn)
triagebot: Autolabel A-rustdoc-json #100763 (triagebot: Autolabel A-rustdoc-json)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

In order to mitigate the Stale Data Read for xAPIC vulnerability completely, reading userspace from an SGX enclave must be aligned and in 8-bytes chunks. References: - https://www.intel.com/content/www/us/en/security-center/advisory/intel-sa-00657.html - https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/advisory-guidance/stale-data-read-from-xapic.html

…ifier

…:fill_utf16_buf`

…dead Mention `as_mut` alongside `as_ref` in borrowck error message Kinda fixes rust-lang#99426 but I guess that really might be better staying open to see if we could make it suggest `as_mut` in a structured way. Not sure how to change borrowck to know that info tho.

…on, r=cuviper Mitigate stale data reads on SGX platform Intel disclosed the Stale Data Read vulnerability yesterday. In order to mitigate this issue completely, reading userspace from an SGX enclave must be aligned and in 8-bytes chunks. This PR implements this mitigation References: - https://www.intel.com/content/www/us/en/security-center/advisory/intel-sa-00657.html - https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/advisory-guidance/stale-data-read-from-xapic.html cc: ``@jethrogb``

…er-errors suggest `once_cell::Lazy` for non-const statics Addresses rust-lang#100410 Some questions: - removing the `if` seems to include too many cases (e.g. calls to non-const functions inside a `const fn`), but this code excludes the following case: ```rust const FOO: Foo = non_const_fn(); ``` Should we suggest `once_cell` in this case as well? - The original issue mentions suggesting `AtomicI32` instead of `Mutex<i32>`, should this PR address that as well?

…errors Suggest the right help message for as_ref Fixes rust-lang#100605

…=davidtwco Migrate "invalid variable declaration" errors to SessionDiagnostic After seeing the great blog post on Inside Rust, I decided to try my hand at this. Just one diagnostic for now to get used to the workflow and to check if this is the way to do it or if there are any problems.

…bol-diagnostic, r=compiler-errors Migrate typeck's `used` expected symbol diagnostic to `SessionDiagnostic` r? ``@davidtwco``

…errors Add the diagnostic translation lints to crates that don't emit them Some of these have a note saying that they should build on a stable compiler, does that mean they shouldn't get these lints? Or can we cfg them out on those?

…nton Avoid zeroing a 1kb stack buffer on every call to `std::sys::windows::fill_utf16_buf` I've also tried to be slightly more careful about integer overflows, although in practice this is likely still not handled ideally. r? `@ChrisDenton`

…-function-qual-error, r=davidtwco improved diagnostic for function defined with `def`, `fun`, `func`, or `function` instead of `fn` Closes rust-lang#99751

triagebot: Autolabel `A-rustdoc-json`

matthiaskrgr · 2022-08-20T05:09:31Z

@bors r+ rollup=never p=10

bors · 2022-08-20T05:09:33Z

📌 Commit 60edec9 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2022-08-20T07:59:52Z

⌛ Testing commit 60edec9 with merge 36e530c...

bors · 2022-08-20T10:21:19Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 36e530c to master...

rust-timer · 2022-08-20T10:24:26Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#100763	a4ec064abbfbb34c9019b27c8ea19a39fa58701a
#100750	38f69970ea02f8b4eb8a1b458efb6ad69ddd8cef
#100729	074318a4042121ba989a7284cdc3d331b0975180
#100723	6096f90ba685e8b8764fcb5ae9b3c0649d753d82
#100709	709548f4b9ce5498137e17ddfef540a64ae6c056
#100667	251b447b23fdcd2be7b16d57106dbd45308ea979
#100617	821baa76a59f37da917b6d9f76f585a464fcbc01
#100507	df6e644eca6b01d9c0f9a6cb7e8044431c2daa08
#100383	7715c6178cdcd862a29747d93bb193f2a2e36a37
#100186	8aa5137a795a6d25f692ee94ce0532b824467b7f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-08-20T11:40:10Z

Finished benchmarking commit (36e530c): comparison url.

Instruction count

Primary benchmarks: ✅ relevant improvement found
Secondary benchmarks: ❌ relevant regressions found

	mean¹	max	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	0.3%	2
Improvements ✅ (primary)	-0.9%	-0.9%	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.9%	-0.9%	1

Max RSS (memory usage)

Results

Primary benchmarks: ❌ relevant regression found
Secondary benchmarks: ✅ relevant improvement found

	mean¹	max	count²
Regressions ❌ (primary)	2.3%	2.3%	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.2%	-3.2%	1
All ❌✅ (primary)	2.3%	2.3%	1

Cycles

Results

Primary benchmarks: mixed results
Secondary benchmarks: ❌ relevant regression found

	mean¹	max	count²
Regressions ❌ (primary)	3.4%	3.4%	1
Regressions ❌ (secondary)	2.9%	2.9%	1
Improvements ✅ (primary)	-3.3%	-3.3%	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	3.4%	2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

compiler-errors and others added 23 commits August 14, 2022 20:23

Suggest as_ref or as_mut

84ba228

suggest lazy-static for non-const statics

34e0d9a

Make as_ref suggestion a note

e37565d

Refactor copying data to userspace

25de53f

Migrate "invalid variable declaration" errors to SessionDiagnostic

e8499cf

ADD - ExpectedUsedSymbol diagnostic to port used() diagnostic

af4f66e

Add diagnostic translation lints to crates that don't emit them

09ea9f0

added improved diagnostic for a function defined with an invalid qual…

1b54ad0

…ifier

Avoid zeroing a 1kb stack buffer on every call to `std::sys::windows:…

f50f878

…:fill_utf16_buf`

Fix comment typo

d4cba61

triagebot: Autolabel A-rustdoc-json

d35749b

Suggest the right help message for as_ref

3de74f7

Rollup merge of rust-lang#100617 - chenyukang:fix-100605, r=compiler-…

61a529d

…errors Suggest the right help message for as_ref Fixes rust-lang#100605

Rollup merge of rust-lang#100709 - JhonnyBillM:port-expected-used-sym…

67f77f5

…bol-diagnostic, r=compiler-errors Migrate typeck's `used` expected symbol diagnostic to `SessionDiagnostic` r? ``@davidtwco``

Rollup merge of rust-lang#100750 - akabinds:akabinds/improved-invalid…

af89769

…-function-qual-error, r=davidtwco improved diagnostic for function defined with `def`, `fun`, `func`, or `function` instead of `fn` Closes rust-lang#99751

Rollup merge of rust-lang#100763 - aDotInTheVoid:triagebot-rdj, r=jyn514

60edec9

triagebot: Autolabel `A-rustdoc-json`

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 20, 2022

klensy mentioned this pull request Aug 20, 2022

Rollup of 7 pull requests #100794

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 20, 2022

bors merged commit 36e530c into rust-lang:master Aug 20, 2022

rustbot added this to the 1.65.0 milestone Aug 20, 2022

bors mentioned this pull request Aug 20, 2022

Stabilize let else #93628

Merged

Xiretza mentioned this pull request Aug 20, 2022

Kind-less SessionDiagnostic derive #100765

Merged

davidtwco removed the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Oct 4, 2022

matthiaskrgr deleted the rollup-dy7rfdh branch October 9, 2022 00:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 10 pull requests#100793

Rollup of 10 pull requests#100793
bors merged 23 commits intorust-lang:masterfrom
matthiaskrgr:rollup-dy7rfdh

matthiaskrgr commented Aug 20, 2022

Uh oh!

matthiaskrgr commented Aug 20, 2022

Uh oh!

bors commented Aug 20, 2022

Uh oh!

bors commented Aug 20, 2022

Uh oh!

bors commented Aug 20, 2022

Uh oh!

rust-timer commented Aug 20, 2022

Uh oh!

rust-timer commented Aug 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Uh oh!

Conversation

matthiaskrgr commented Aug 20, 2022

Uh oh!

matthiaskrgr commented Aug 20, 2022

Uh oh!

bors commented Aug 20, 2022

Uh oh!

bors commented Aug 20, 2022

Uh oh!

bors commented Aug 20, 2022

Uh oh!

rust-timer commented Aug 20, 2022

Uh oh!

rust-timer commented Aug 20, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants