Porting 'compiler/rustc_trait_selection' to translatable diagnostics - Part 1#100814
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 2, 2022
Merged
Conversation
rustbot
added
A-translation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
davidtwco
reviewed
Aug 23, 2022
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
This is a great start, left a comment or two
compiler/rustc_error_messages/locales/en-US/trait_selection.ftl
Outdated
Show resolved
Hide resolved
Member
|
r? @davidtwco |
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
We have a no merge policy, do you think you could remove those merge commits? :) |
gabrielbusta
force-pushed
the
port_trait_selection_diagnostics
branch
from
2fbc967 to
1b81e3a
Compare
gabrielbusta
changed the title
rustc_trait_selection diagnostics
Collaborator
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
gabrielbusta
force-pushed
the
port_trait_selection_diagnostics
branch
from
1b81e3a to
18feed3
Compare
davidtwco
reviewed
Aug 30, 2022
gabrielbusta
force-pushed
the
port_trait_selection_diagnostics
branch
2 times, most recently
from
1d24c51 to
013994a
Compare
davidtwco
reviewed
Aug 31, 2022
gabrielbusta
force-pushed
the
port_trait_selection_diagnostics
branch
2 times, most recently
from
413d176 to
06a2d5b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
gabrielbusta
force-pushed
the
port_trait_selection_diagnostics
branch
from
06a2d5b to
8e82200
Compare
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 2, 2022
…diagnostics, r=davidtwco Porting 'compiler/rustc_trait_selection' to translatable diagnostics - Part 1 `@rustbot` label +A-translation r? rust-lang/diagnostics cc rust-lang#100717
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 2, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#100121 (Try normalizing types without RevealAll in ParamEnv in MIR validation) - rust-lang#100200 (Change implementation of `-Z gcc-ld` and `lld-wrapper` again) - rust-lang#100814 ( Porting 'compiler/rustc_trait_selection' to translatable diagnostics - Part 1) - rust-lang#101215 (Also replace the version placeholder in rustc_attr) - rust-lang#101260 (Use `FILE_ATTRIBUTE_TAG_INFO` to get reparse tag) - rust-lang#101323 (Remove unused .toggle-label CSS rule) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rustbot label +A-translation
r? rust-lang/diagnostics
cc #100717