Rollup of 8 pull requests by Dylan-DPC · Pull Request #100881 · rust-lang/rust

Dylan-DPC · 2022-08-22T15:04:17Z

Successful merges:

Expand potential inner Or pattern for THIR #98200 (Expand potential inner Or pattern for THIR)
Make some const prop mir-opt tests unit-tests #99770 (Make some const prop mir-opt tests unit-tests)
Rework Ipv6Addr::is_global to check for global reachability rather than global scope - rebase #99957 (Rework Ipv6Addr::is_global to check for global reachability rather than global scope - rebase)
Guarantee try_reserve preserves the contents on error #100331 (Guarantee try_reserve preserves the contents on error)
Fix two const_trait_impl issues #100336 (Fix two const_trait_impl issues)
Convert diagnostics in parser/expr to SessionDiagnostic #100713 (Convert diagnostics in parser/expr to SessionDiagnostic)
Use pointer is_aligned* methods #100820 (Use pointer is_aligned* methods)
Add guarantee that Vec::default() does not alloc #100872 (Add guarantee that Vec::default() does not alloc)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

…n global scope

Rebasing off master

…om the globally reachable change

Update doc comments to make the guarantee explicit. However, some implementations does not have the statement though. * `HashMap`, `HashSet`: require guarantees on hashbrown side. * `PathBuf`: simply redirecting to `OsString`. Fixes rust-lang#99606.

Currently `Vec::new()` is guaranteed to not allocate until elements are pushed onto the `Vec`, but such a guarantee is missing for `Vec`'s implementation of `Default::default`. This adds such a guarantee for `Vec::default()` to the API reference.

Expand potential inner `Or` pattern for THIR Code assumed there wouldn't be a deeper `Or` pattern inside expanded `PatStack` this fixes it by looking for the `Or` pattern inside expanded `PatStack`. A more ideal solution would be recursively doing this but I haven't found a good way to do that. _fixes #97898_

…-obk Make some const prop mir-opt tests `unit-test`s Most of these have no or only tiny diffs beyond line numbers being changed (would it make sense to not have line numbers in mir-opt tests?). Some things changed a bit, but I think it should all be fine, not sure though.

…se, r=Mark-Simulacrum Rework Ipv6Addr::is_global to check for global reachability rather than global scope - rebase Rebasing of pull request rust-lang#86634 off of master to try and get the feature "ip" stabilized. I also found a test failure in the rebase that is_global was considering the benchmark space to be globally reachable. This is related to my other rebasing pull request rust-lang#99947

…ilure, r=thomcc Guarantee `try_reserve` preserves the contents on error Update doc comments to make the guarantee explicit. However, some implementations does not have the statement though. * `HashMap`, `HashSet`: require guarantees on hashbrown side. * `PathBuf`: simply redirecting to `OsString`. Fixes rust-lang#99606.

…it, r=oli-obk Fix two const_trait_impl issues r? ``@oli-obk`` Fixes rust-lang#100222. Fixes rust-lang#100543.

…stics, r=estebank Convert diagnostics in parser/expr to SessionDiagnostic This migrates all the easy cases in `rustc_parse::parser::expr` to `SessionDiagnostic`s, I've left things such as `multipart_suggestion`s out for now in the hopes of a derive API being developed soon.

…thods, r=scottmcm Use pointer `is_aligned*` methods This PR replaces some manual alignment checks with calls to `pointer::{is_aligned, is_aligned_to}` and removes a useless pointer cast. r? `@scottmcm` _split off from #100746_

…=fee1-dead Add guarantee that Vec::default() does not alloc Currently `Vec::new()` is guaranteed to not allocate until elements are pushed onto the `Vec`, but such a guarantee is missing for `Vec`'s implementation of `Default::default`. This adds such a guarantee for `Vec::default()` to the API reference. See also [this discussion on URLO](https://users.rust-lang.org/t/guarantee-that-vec-default-does-not-allocate/79903).

Dylan-DPC · 2022-08-22T15:05:22Z

@bors r+ rollup=never p=5

bors · 2022-08-22T15:05:28Z

📌 Commit 4ed8fa4 has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2022-08-22T17:47:01Z

⌛ Testing commit 4ed8fa4 with merge a785176...

bors · 2022-08-22T20:28:09Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing a785176 to master...

rust-timer · 2022-08-22T20:30:43Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#100872	c2b4d4b3ef0840fe563be02ba1bc2114e22df88f
#100820	35e7b74e3e0b082cfdf411854ecd26f9bcf18a66
#100713	69fd185feb8ecbdcc504c57a0527695f59655236
#100336	7c4f411ba347c4ff243d6e82d479a94738c2e822
#100331	be266d1d73c277413a39ab79d6e17343830ad56e
#99957	bab168a6bc5cc290a64c741786c9b9814ee08908
#99770	206190c7afe26b78901375870b88c5a48b24da14
#98200	7e6bf2b64ecefbceeaaeeecdb988e603b29f2634

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-08-22T21:43:17Z

Finished benchmarking commit (a785176): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	0.6%	[0.5%, 0.7%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.5%, 0.7%]	2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	2
Improvements ✅ (secondary)	-1.9%	[-1.9%, -1.9%]	2
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.0%	[1.2%, 2.9%]	2
Regressions ❌ (secondary)	3.4%	[3.4%, 3.4%]	1
Improvements ✅ (primary)	-3.2%	[-3.2%, -3.2%]	1
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	0.3%	[-3.2%, 2.9%]	3

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

ouz-a and others added 25 commits June 17, 2022 21:38

expand inner or pattern

90abfe9

use true recursion

661d488

Fix Ipv6Addr::is_global to check for global reachability rather tha…

f7d8805

…n global scope

Change Ipv4Addr::is_global to be in line with Ipv6Addr::is_global

f299064

Rebasing off master

Reincorporated changes from rust-lang#87689

3365b06

Original branch seems to have missed excluding the benchmark range fr…

f659088

…om the globally reachable change

make some const prop tests unit-test

ee30cc8

add new test and combine old ones

ddf23cb

Remove useless pointer cast

ed084ba

Make use of pointer::is_aligned[_to]

efef211

Migrate diagnostics in parser/expr to SessionDiagnostic

ffcaa0d

Fix wf check on #[const_trait] return types

d744f36

remove stray comment

460daf3

Overhaul 100222 test; wf always remap to nonconst

f019b6c

fix tidy

f1db3be

Rollup merge of rust-lang#100336 - fee1-dead-contrib:fix-wf-const-tra…

14c8a68

…it, r=oli-obk Fix two const_trait_impl issues r? ``@oli-obk`` Fixes rust-lang#100222. Fixes rust-lang#100543.

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 22, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 22, 2022

bors merged commit a785176 into rust-lang:master Aug 22, 2022

rustbot added this to the 1.65.0 milestone Aug 22, 2022

This was referenced Aug 22, 2022

Fix Ipv6Addr::is_unicast_global to check for unicast global scope rebase #99947

Merged

Use DisplayBuffer for socket addresses. #100640

Merged

Make use of [wrapping_]byte_{add,sub} #100819

Merged

Dylan-DPC deleted the rollup-q9rr658 branch August 23, 2022 05:23

davidtwco removed the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Oct 4, 2022

matthiaskrgr mentioned this pull request Jan 7, 2024

ICE: effects, gce: difference in caller_arg caller_abi layout #119701

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 8 pull requests#100881

Rollup of 8 pull requests#100881
bors merged 25 commits intorust-lang:masterfrom
Dylan-DPC:rollup-q9rr658

Dylan-DPC commented Aug 22, 2022

Uh oh!

Dylan-DPC commented Aug 22, 2022

Uh oh!

bors commented Aug 22, 2022

Uh oh!

bors commented Aug 22, 2022

Uh oh!

bors commented Aug 22, 2022

Uh oh!

rust-timer commented Aug 22, 2022

Uh oh!

rust-timer commented Aug 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Uh oh!

Conversation

Dylan-DPC commented Aug 22, 2022

Uh oh!

Dylan-DPC commented Aug 22, 2022

Uh oh!

bors commented Aug 22, 2022

Uh oh!

bors commented Aug 22, 2022

Uh oh!

bors commented Aug 22, 2022

Uh oh!

rust-timer commented Aug 22, 2022

Uh oh!

rust-timer commented Aug 22, 2022

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants