Allow deriving multipart suggestions#100970
Merged
bors merged 5 commits intorust-lang:masterfrom Aug 31, 2022
Merged
Conversation
Collaborator
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
rustbot
added
A-translation
rust-highfive
added
the
S-waiting-on-review
Xiretza
commented
Aug 25, 2022
Xiretza
commented
Aug 25, 2022
davidtwco
requested changes
Aug 25, 2022
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
This is really great, thanks for working on it. I'm excited to have this additional capability - do you think it would be too much additional work to go through and convert some of the manual AddToDiagnostic impls in error.rs files to use this in a commit?
src/test/ui-fulldeps/session-diagnostic/subdiagnostic-derive.rs
Outdated
Show resolved
Hide resolved
davidtwco
added
S-waiting-on-author
Xiretza
force-pushed
the
derive-multipart-suggestion
branch
3 times, most recently
from
6993b27 to
62e35e4
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
davidtwco
approved these changes
Aug 26, 2022
src/test/ui-fulldeps/session-diagnostic/subdiagnostic-derive.stderr
Outdated
Show resolved
Hide resolved
Xiretza
force-pushed
the
derive-multipart-suggestion
branch
from
62e35e4 to
72541dd
Compare
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Aug 27, 2022
…n, r=davidtwco Allow deriving multipart suggestions This turned into a bit more of a rewrite than I was initially hoping for... Still, I think the `SessionSubdiagnostic` derive is a little cleaner overall now, and closer to the `SessionDiagnostic` derive to make future code sharing easier. r? `@davidtwco`
This comment was marked as resolved.
This comment was marked as resolved.
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-author
Xiretza
force-pushed
the
derive-multipart-suggestion
branch
from
72541dd to
91c3323
Compare
Xiretza
force-pushed
the
derive-multipart-suggestion
branch
from
91c3323 to
31b939b
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 31, 2022
…n, r=davidtwco Allow deriving multipart suggestions This turned into a bit more of a rewrite than I was initially hoping for... Still, I think the `SessionSubdiagnostic` derive is a little cleaner overall now, and closer to the `SessionDiagnostic` derive to make future code sharing easier. r? `@davidtwco`
This was referenced Aug 31, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 31, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#100970 (Allow deriving multipart suggestions) - rust-lang#100984 (Reinstate preloading of some dll imports) - rust-lang#101011 (Use getentropy when possible on all Apple platforms) - rust-lang#101025 (Add tier-3 support for powerpc64 and riscv64 openbsd) - rust-lang#101049 (Remove span fatal from ast lowering) - rust-lang#101100 (Make call suggestions more general and more accurate) - rust-lang#101171 (Fix UB from misalignment and provenance widening in `std::sys::windows`) - rust-lang#101185 (Tweak `WellFormedLoc`s a bit) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 2, 2022
…idtwco Fix rust-lang#100844 rebase accident This undoes the rebase accident in rust-lang#100844, which accidentally caused rust-lang#100970 to be reverted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turned into a bit more of a rewrite than I was initially hoping for... Still, I think the
SessionSubdiagnosticderive is a little cleaner overall now, and closer to theSessionDiagnosticderive to make future code sharing easier.r? @davidtwco