translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 2 by beowolx · Pull Request #101041 · rust-lang/rust

beowolx · 2022-08-26T14:08:29Z

Description

This is the second part of the rustc_session migration.

Please only review this commit that belongs to the part 2. The other ones are from the PR #100753 that is not yet merged.

In this PR, we migrate the files session.rs and config.rs.

Please not that we have to allow the lints rules in some functions from session.rs because they are (at least I believe) part of the diagnostic machinery.

rust-highfive · 2022-08-26T14:08:32Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @TaKO8Ki (or someone else) soon.

Please see the contribution instructions for more information.

rustbot · 2022-08-30T19:57:19Z

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

beowolx · 2022-08-30T19:57:39Z

@rustbot ready

beowolx · 2022-08-30T20:13:16Z

r? @davidtwco

compiler/rustc_session/src/session.rs

…t-no-self-lint, r=fee1-dead lint: avoid linting diag functions with diag lints Functions annotated with `#[rustc_lint_diagnostics]` are used by the diagnostic migration lints to know when to lint, but functions that are annotated with this attribute shouldn't themselves be linted. cc rust-lang#100717 rust-lang#101041 (comment)

davidtwco

This is almost ready, I've left one additional suggestion.

compiler/rustc_session/src/config.rs

compiler/rustc_error_messages/locales/en-US/session.ftl

compiler/rustc_session/src/session.rs

beowolx · 2022-09-07T07:13:26Z

I have just amended my last commit with some of the changes requested by @davidtwco and you can check the diff here.

This thread still not resolved.

davidtwco

r=me unless #101041 (comment) needs more work

…rked with rustc_lint_diagnostic This commit removes the allows rules for the SessionDiagnostic lint that were being used in the session.rs file. Thanks to the PR #101230 we do not need to annotate the methods with the allow rule as they are part of the diagnostic machinery.

compiler/rustc_error_messages/locales/en-US/session.ftl

davidtwco

r=me after removing the unused Fluent message

beowolx · 2022-09-08T10:23:38Z

r? @davidtwco

davidtwco · 2022-09-08T10:25:10Z

@bors r+

bors · 2022-09-08T10:25:12Z

📌 Commit 0e497a7 has been approved by davidtwco

It is now in the queue for this repository.

…name-attr-warning-pt2, r=davidtwco translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 2 # Description This is the second part of the `rustc_session` [migration](rust-lang#100717 (comment)). **Please only review this [commit](rust-lang@5018581) that belongs to the part 2. The other ones are from the PR [rust-lang#100753](rust-lang#100753) that is not yet merged.** In this PR, we migrate the files `session.rs` and `config.rs`. Please not that we have to `allow` the lints rules in some functions from `session.rs` because they are (at least I believe) part of the diagnostic machinery.

Rollup of 7 pull requests Successful merges: - rust-lang#98933 (Opaque types' generic params do not imply anything about their hidden type's lifetimes) - rust-lang#101041 (translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 2) - rust-lang#101424 (Adjust and slightly generalize operator error suggestion) - rust-lang#101496 (Allow lower_lifetime_binder receive a closure) - rust-lang#101501 (Allow lint passes to be bound by `TyCtxt`) - rust-lang#101515 (Recover from typo where == is used in place of =) - rust-lang#101545 (Remove unnecessary `PartialOrd` and `Ord`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…stcsession-pt3, r=davidtwco translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Final # Description This is the final part of the rustc_session rust-lang#100717 (comment). Please only review this [commit](rust-lang@a545347). The other ones are from the PR rust-lang#101041 that is not yet merged. In this PR, we migrate the file `output.rs`

Rollup of 7 pull requests Successful merges: - rust-lang#98933 (Opaque types' generic params do not imply anything about their hidden type's lifetimes) - rust-lang#101041 (translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 2) - rust-lang#101424 (Adjust and slightly generalize operator error suggestion) - rust-lang#101496 (Allow lower_lifetime_binder receive a closure) - rust-lang#101501 (Allow lint passes to be bound by `TyCtxt`) - rust-lang#101515 (Recover from typo where == is used in place of =) - rust-lang#101545 (Remove unnecessary `PartialOrd` and `Ord`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned TaKO8Ki Aug 26, 2022

rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 26, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2022

beowolx marked this pull request as ready for review August 30, 2022 19:57

beowolx mentioned this pull request Aug 30, 2022

Diagnostic Translation #100717

Open

84 tasks

rust-highfive assigned davidtwco and unassigned TaKO8Ki Aug 30, 2022

davidtwco reviewed Aug 31, 2022

View reviewed changes

compiler/rustc_session/src/session.rs Outdated Show resolved Hide resolved

davidtwco reviewed Aug 31, 2022

View reviewed changes

compiler/rustc_session/src/session.rs Outdated Show resolved Hide resolved

davidtwco reviewed Aug 31, 2022

View reviewed changes

compiler/rustc_session/src/session.rs Outdated Show resolved Hide resolved

davidtwco mentioned this pull request Aug 31, 2022

lint: avoid linting diag functions with diag lints #101230

Merged

This comment was marked as resolved.

Sign in to view

beowolx mentioned this pull request Sep 1, 2022

translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Final #101266

Merged

davidtwco requested changes Sep 1, 2022

View reviewed changes

compiler/rustc_session/src/config.rs Outdated Show resolved Hide resolved

davidtwco reviewed Sep 6, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

davidtwco approved these changes Sep 7, 2022

View reviewed changes

beowolx added 3 commits September 8, 2022 08:30

translations(rustc_session): migrates session.rs and config.rs

60b4958

translations(rustc_session): migrate TargetDataLayout::parse

0f06320

davidtwco reviewed Sep 8, 2022

View reviewed changes

compiler/rustc_error_messages/locales/en-US/session.ftl Outdated Show resolved Hide resolved

davidtwco approved these changes Sep 8, 2022

View reviewed changes

translations(rustc_session): migrates two diagnostics in session.rs

0e497a7

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2022

Dylan-DPC mentioned this pull request Sep 8, 2022

Rollup of 6 pull requests #101575

Closed

This was referenced Sep 8, 2022

Rollup of 7 pull requests #101576

Closed

Rollup of 7 pull requests #101577

Merged

bors merged commit 1561922 into rust-lang:master Sep 8, 2022

rustbot added this to the 1.65.0 milestone Sep 8, 2022

beowolx deleted the translation-rename-attr-warning-pt2 branch September 9, 2022 06:19

Uh oh!

Conversation

beowolx commented Aug 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

rust-highfive commented Aug 26, 2022

Uh oh!

rustbot commented Aug 30, 2022

Uh oh!

beowolx commented Aug 30, 2022

Uh oh!

beowolx commented Aug 30, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

davidtwco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

beowolx commented Sep 7, 2022

Uh oh!

This comment has been minimized.

davidtwco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidtwco left a comment

Choose a reason for hiding this comment

Uh oh!

beowolx commented Sep 8, 2022

Uh oh!

davidtwco commented Sep 8, 2022

Uh oh!

bors commented Sep 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

beowolx commented Aug 26, 2022 •

edited

Loading