Rollup of 9 pull requests

[compiler-errors]

Successful merges:

• Migrate ast lowering to session diagnostic #100724 (Migrate ast lowering to session diagnostic)
• Migrate rustc_ty_utils to SessionDiagnostic #100735 (Migrate rustc_ty_utils to SessionDiagnostic)
• Diagnostics migr const eval #100738 (Diagnostics migr const eval)
• Migrate rustc_mir_dataflow to diagnostic structs #100744 (Migrate rustc_mir_dataflow to diagnostic structs)
• Migrate rustc_lint errors to SessionDiagnostic #100776 (Migrate rustc_lint errors to SessionDiagnostic)
• sugg: suggest the usage of boolean value when there is a typo in the keyword #100817 (sugg: suggest the usage of boolean value when there is a typo in the keyword)
• Migrate rustc_attr crate diagnostics #100836 (Migrate rustc_attr crate diagnostics)
• Migrate rustc_driver to SessionDiagnostic #100890 (Migrate rustc_driver to SessionDiagnostic)
• on region_errors.rs #100900 (on region_errors.rs)

Failed merges:

• Migrate symbol_mangling module to new diagnostics structs #100831 (Migrate symbol_mangling module to new diagnostics structs)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[compiler-errors]

Tried to roll up all of the translation PRs into one cc @davidtwco

[compiler-errors]

Well I also included one that wasn't a translation PR but oh well.

[compiler-errors]

@bors r+ rollup=never p=5

[bors]

📌 Commit 96ceadd has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 96ceadd with merge bb8a08f...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing bb8a08f to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#100900	25a3dd1cc3f735528343d193b6061a783875e14b
#100890	537e82ad53aa26f8b7404df262b79c41bbb840ce
#100836	2aab459e883e3d669ec9fb7255122e113bd8250d
#100817	01c2feedc13fc35a1b44e1ccf93db88482165878
#100776	e8491e61b978df8e058c354473207f549024964e
#100744	97dfacf3a0a4fbd6ed13bbd2eb0664dd7f0a45ec
#100738	c1d27de045d3ce83d193db91a14c67561d6d3ae9
#100735	7b8d7d63e78db8839a644608fb9cd1721973ffec
#100724	d470ac3c77810cca7d2e115f6d334bc3aea14617

previous master: 2b443a8d97

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (bb8a08f): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	0.6%	[0.5%, 0.7%]	6
Regressions ❌ (secondary)	1.0%	[1.0%, 1.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.3%	[-1.5%, -1.3%]	3
All ❌✅ (primary)	0.6%	[0.5%, 0.7%]	6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.8%	[-7.8%, -7.8%]	1
All ❌✅ (primary)	2.5%	[2.5%, 2.5%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	3.0%	[2.1%, 4.2%]	3
Regressions ❌ (secondary)	2.2%	[2.1%, 2.2%]	2
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.7%	[-2.0%, 4.2%]	4

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[nnethercote]

html5ever-0.26.0 has become very noisy lately, so I think this is a phantom regression.

@rustbot label: -perf-regression