Migrate rustc_codegen_gcc to SessionDiagnostics by ellishg · Pull Request #101075 · rust-lang/rust

ellishg · 2022-08-27T04:24:39Z

As part of #100717 this pr migrates diagnostics to SessionDiagnostics for the rustc_codegen_gcc crate.

@rustbot label +A-translation

rust-highfive · 2022-08-27T04:24:42Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon.

Please see the contribution instructions for more information.

rustbot · 2022-08-27T04:24:42Z

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

ellishg · 2022-08-27T04:40:01Z

The diagnostics I'm missing come from
https://github.com/rust-lang/rust/blob/913350ecaf6a0fc621c6c43f0764956e1c47cc15/compiler/rustc_codegen_gcc/src/context.rs#L478-L484

I saw something similar in rustc_codegen_llvm but #101005 has not finished yet.

I also found some calls to span_invalid_monomorphization_error() that I suspect need to be changed.

https://github.com/rust-lang/rust/blob/913350ecaf6a0fc621c6c43f0764956e1c47cc15/compiler/rustc_codegen_gcc/src/intrinsic/simd.rs#L27-L30
https://github.com/rust-lang/rust/blob/913350ecaf6a0fc621c6c43f0764956e1c47cc15/compiler/rustc_codegen_gcc/src/intrinsic/simd.rs#L453-L456

These were not caught by #![deny(...)] and I'm not sure if that means they don't need to be translated, or if this is an edge case.

nagisa · 2022-08-29T10:15:35Z

r? @compiler-errors / @davidtwco

compiler/rustc_errors/src/diagnostic.rs

davidtwco · 2022-08-30T15:01:28Z

The diagnostics I'm missing come from

https://github.com/rust-lang/rust/blob/913350ecaf6a0fc621c6c43f0764956e1c47cc15/compiler/rustc_codegen_gcc/src/context.rs#L478-L484

I saw something similar in rustc_codegen_llvm but #101005 has not finished yet.

I feel like LayoutError could basically implement SessionDiagnostic, maybe we could implement it for Spanned<LayoutError> (Spanned)?

I also found some calls to span_invalid_monomorphization_error() that I suspect need to be changed.

https://github.com/rust-lang/rust/blob/913350ecaf6a0fc621c6c43f0764956e1c47cc15/compiler/rustc_codegen_gcc/src/intrinsic/simd.rs#L27-L30

https://github.com/rust-lang/rust/blob/913350ecaf6a0fc621c6c43f0764956e1c47cc15/compiler/rustc_codegen_gcc/src/intrinsic/simd.rs#L453-L456

These were not caught by #![deny(...)] and I'm not sure if that means they don't need to be translated, or if this is an edge case.

These should be translated, and ideally the lint would fire on them, I've added a link to this to #100717 so someone can go fix that.

davidtwco

This is a great start, thanks!

compiler/rustc_codegen_gcc/src/errors.rs

davidtwco · 2022-09-02T10:09:50Z

This is great progress, I'd like it if you could address the feedback from my earlier comment (#101075 (comment)) :)

ellishg · 2022-09-03T17:10:43Z

The diagnostics I'm missing come from
https://github.com/rust-lang/rust/blob/913350ecaf6a0fc621c6c43f0764956e1c47cc15/compiler/rustc_codegen_gcc/src/context.rs#L478-L484

I saw something similar in rustc_codegen_llvm but #101005 has not finished yet.

I feel like LayoutError could basically implement SessionDiagnostic, maybe we could implement it for Spanned<LayoutError> (Spanned)?

I tried to implement SessionDiagnostic for LayoutError and Spanned<T>, but I ended up getting lifetime errors. I don't quite understand it, but I think it was related to 'gcc and tcx being different lifetimes.

I also found some calls to span_invalid_monomorphization_error() that I suspect need to be changed.
https://github.com/rust-lang/rust/blob/913350ecaf6a0fc621c6c43f0764956e1c47cc15/compiler/rustc_codegen_gcc/src/intrinsic/simd.rs#L27-L30

https://github.com/rust-lang/rust/blob/913350ecaf6a0fc621c6c43f0764956e1c47cc15/compiler/rustc_codegen_gcc/src/intrinsic/simd.rs#L453-L456

These were not caught by #![deny(...)] and I'm not sure if that means they don't need to be translated, or if this is an edge case.

These should be translated, and ideally the lint would fire on them, I've added a link to this to #100717 so someone can go fix that.

I'm still working on this. I think I need to create a new function similar to span_invalid_monomorphization_error() that takes a SessionDiagnostic. I also realized there are lots of other untranslatable strings in simd.rs that I would need to fix.

davidtwco · 2022-09-06T10:25:12Z

I tried to implement SessionDiagnostic for LayoutError and Spanned<T>, but I ended up getting lifetime errors. I don't quite understand it, but I think it was related to 'gcc and tcx being different lifetimes.

If you share the code from your attempt then maybe we can work this out.

compiler/rustc_codegen_gcc/src/context.rs

compiler/rustc_error_messages/locales/en-US/codegen_gcc.ftl

compiler/rustc_codegen_gcc/src/intrinsic/simd.rs

compiler/rustc_error_messages/locales/en-US/codegen_gcc.ftl

compiler/rustc_session/src/session.rs

davidtwco · 2022-09-22T13:50:25Z

Apologies for the delay in responding to this, replied to the pending comments now.

ellishg · 2022-09-24T18:44:19Z

I've finally figured out the lifetime error. Thanks @davidtwco for all your help! I believe I've migrated all the diagnostics so this is ready for review!

antoyo

LGTM

compiler/rustc_codegen_gcc/src/intrinsic/simd.rs

davidtwco

This looks great, left a few comments

compiler/rustc_codegen_gcc/src/errors.rs

compiler/rustc_error_messages/locales/en-US/codegen_gcc.ftl

davidtwco · 2022-09-29T08:16:03Z

@bors r+

bors · 2022-09-29T08:16:04Z

📌 Commit 01439c9 has been approved by davidtwco

It is now in the queue for this repository.

…ics, r=davidtwco Migrate rustc_codegen_gcc to SessionDiagnostics As part of rust-lang#100717 this pr migrates diagnostics to `SessionDiagnostics` for the `rustc_codegen_gcc` crate. `@rustbot` label +A-translation

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#101075 (Migrate rustc_codegen_gcc to SessionDiagnostics ) - rust-lang#102350 (Improve errors for incomplete functions in struct definitions) - rust-lang#102481 (rustdoc: remove unneeded CSS `.rust-example-rendered { position }`) - rust-lang#102491 (rustdoc: remove no-op source sidebar `opacity`) - rust-lang#102499 (Adjust the s390x data layout for LLVM 16) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…ics, r=davidtwco Migrate rustc_codegen_gcc to SessionDiagnostics As part of rust-lang#100717 this pr migrates diagnostics to `SessionDiagnostics` for the `rustc_codegen_gcc` crate. ``@rustbot`` label +A-translation

rust-highfive assigned nagisa Aug 27, 2022

rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 27, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2022

ellishg force-pushed the rustc_codegen_gcc_diagnostics branch from 24a7f55 to 913350e Compare August 27, 2022 04:26

ellishg mentioned this pull request Aug 28, 2022

Format rustc_codegen_gcc #101104

Closed

rust-highfive assigned compiler-errors and unassigned nagisa Aug 29, 2022

compiler-errors reviewed Aug 29, 2022

View reviewed changes

compiler/rustc_errors/src/diagnostic.rs Outdated Show resolved Hide resolved

davidtwco mentioned this pull request Aug 30, 2022

Diagnostic Translation #100717

Open

84 tasks

davidtwco reviewed Aug 30, 2022

View reviewed changes

compiler/rustc_codegen_gcc/src/errors.rs Outdated Show resolved Hide resolved

compiler/rustc_codegen_gcc/src/errors.rs Outdated Show resolved Hide resolved

ellishg force-pushed the rustc_codegen_gcc_diagnostics branch from 6c8fa90 to 5765171 Compare September 1, 2022 22:25

ellishg commented Sep 12, 2022

View reviewed changes

compiler/rustc_codegen_gcc/src/context.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

ellishg commented Sep 12, 2022

View reviewed changes

compiler/rustc_error_messages/locales/en-US/codegen_gcc.ftl Outdated Show resolved Hide resolved

ellishg force-pushed the rustc_codegen_gcc_diagnostics branch from 655c3fa to 1e3d953 Compare September 12, 2022 01:12

davidtwco reviewed Sep 12, 2022

View reviewed changes

compiler/rustc_codegen_gcc/src/intrinsic/simd.rs Outdated Show resolved Hide resolved

compiler/rustc_error_messages/locales/en-US/codegen_gcc.ftl Outdated Show resolved Hide resolved

compiler/rustc_session/src/session.rs Outdated Show resolved Hide resolved

ellishg force-pushed the rustc_codegen_gcc_diagnostics branch from 1e3d953 to 22dbcb0 Compare September 13, 2022 21:21

This comment was marked as resolved.

Sign in to view

ellishg added 2 commits September 24, 2022 10:24

Add RanlibFailure

9363f0f

Add LinkageConstOrMutType

7e00a48

ellishg added 7 commits September 24, 2022 10:24

Lint against untranslatable diagnostics in rustc_codegen_gcc

1ce482a

remove IntoDiagnosticArg impl for Option

fb488ad

Add wrapper type for ExitCode for use in RanlibFailure

e906ea8

lint type

6fdfcb3

Add monomorphization errors

249e46b

impl SessionDiagnostic for LayoutError and Spanned<T>

6e22c0a

rebase and update trait names

5c7e629

ellishg force-pushed the rustc_codegen_gcc_diagnostics branch from 22dbcb0 to 5c7e629 Compare September 24, 2022 18:09

fix lifetime error

ac97487

antoyo reviewed Sep 24, 2022

View reviewed changes

compiler/rustc_codegen_gcc/src/intrinsic/simd.rs Outdated Show resolved Hide resolved

remove comment

d7bee58

davidtwco reviewed Sep 26, 2022

View reviewed changes

ellishg added 2 commits September 26, 2022 19:57

lint and remove unused diagnostic

6d01c6d

print <signal> when ranlib failed without an exit code

01439c9

davidtwco approved these changes Sep 29, 2022

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2022

matthiaskrgr mentioned this pull request Sep 30, 2022

Rollup of 5 pull requests #102504

Closed

matthiaskrgr mentioned this pull request Sep 30, 2022

Rollup of 5 pull requests #102509

Merged

bors merged commit 25017f8 into rust-lang:master Sep 30, 2022

rustbot added this to the 1.66.0 milestone Sep 30, 2022

ellishg deleted the rustc_codegen_gcc_diagnostics branch October 1, 2022 15:47

Uh oh!

Conversation

ellishg commented Aug 27, 2022

Uh oh!

rust-highfive commented Aug 27, 2022

Uh oh!

rustbot commented Aug 27, 2022

Uh oh!

ellishg commented Aug 27, 2022

Uh oh!

nagisa commented Aug 29, 2022

Uh oh!

Uh oh!

davidtwco commented Aug 30, 2022

Uh oh!

davidtwco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

davidtwco commented Sep 2, 2022

Uh oh!

ellishg commented Sep 3, 2022

Uh oh!

davidtwco commented Sep 6, 2022

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

davidtwco commented Sep 22, 2022

Uh oh!

ellishg commented Sep 24, 2022

Uh oh!

antoyo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidtwco left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidtwco commented Sep 29, 2022

Uh oh!

bors commented Sep 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

davidtwco left a comment •

edited

Loading