Merged
Conversation
Without this change, in <https://doc.rust-lang.org/1.63.0/std/#primitives>, `reference` is the only entry in that list which does not contain the syntax by which the type is named in source code. With this change, it contains them, in roughly the same way as the `pointer` entry does.
… is just impossible
…n they have items. Fixes rust-lang#101103 Fixes rust-lang#100973
…ds, r=spastorino
Do not report too many expr field candidates
When considering "this expressions' field has a {field/method}" suggestions:
1. Don't report methods that are out of scope
2. Use `span_suggestions` instead of reporting each field candidate, which caps the number of suggestions to 4
4. Blacklist some common traits like `Clone` and `Deref`
Fixes rust-lang#100894
Add the syntax of references to their documentation summary. Without this change, in <https://doc.rust-lang.org/1.63.0/std/#primitives>, `reference` is the only entry in that list which does not contain the syntax by which the type is named in source code. With this change, it contains them, in roughly the same way as the `pointer` entry does.
…GuillaumeGomez Rustdoc-Json: Retain Stripped Modules when they are imported, not when they have items Fixes rust-lang#101103 Fixes rust-lang#100973 r? `@GuillaumeGomez`
CTFE: exposing pointers and calling extern fn is just impossible The remaining "needs RFC" errors are just needlessly confusing, I think -- time to get rid of that error variant. They are anyway only reachable with miri-unleashed (if at all). r? `@oli-obk`
…-misleading-name, r=oli-obk Simplify `get_trait_ref` fn used for `virtual_function_elimination` 1. The name `get_trait_ref` is misleading, so I renamed it to something more like `expect_...` because it ICEs if used incorrectly. 2. No need to manually go through the existential trait refs, we already have `.principal()` for that.
…ler-errors Various changes to logging of borrowck-related code Cleanups found when doing other changes r? `@compiler-errors`
…mpiler-errors Remove `Sync` requirement from lint pass objects This is blocking the clippy sync (rust-lang#101140). One of the lint passes contains a `Cell` in order to make lifetimes work. It could be worked around, but this is the easier change to make if there are no objections. Rational for removing the requirement * All lint pass methods take `&mut self` arguments. * Many passes depend on running is visitor order. * Lint passes are created on demand so they're only ever stored in a local. * `Send` is enough to lint different passes in parallel. `LintStore` remains `Sync` with this. The constructor functions it contains still maintain their `Sync` requirement. r? rust-lang/compiler
rustbot
added
A-rustdoc-json
Member
Author
|
@bors r+ rollup=never p=7 |
Collaborator
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: bc4b39c271 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (9f4d5d2): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
get_trait_reffn used forvirtual_function_elimination#101141 (Simplifyget_trait_reffn used forvirtual_function_elimination)Syncrequirement from lint pass objects #101156 (RemoveSyncrequirement from lint pass objects)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup