Skip to content

Also replace the version placeholder in rustc_attr#101215

Merged
bors merged 1 commit intorust-lang:masterfrom
est31:rustdoc_version_placeholder
Sep 2, 2022
Merged

Also replace the version placeholder in rustc_attr#101215
bors merged 1 commit intorust-lang:masterfrom
est31:rustdoc_version_placeholder

Conversation

@est31
Copy link
Member

@est31 est31 commented Aug 30, 2022

Replace the version placeholder with the current version in the rustc_attr crate too so that users won't see the placeholder but instead the explicit version. This especially fixes the bug for rustdoc not showing it but instead the placeholder.

Originally reported here.

cc #100591

Screenshot_20220830_233727

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 30, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented Aug 30, 2022

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2022
@est31
Copy link
Member Author

est31 commented Aug 30, 2022

r? @Mark-Simulacrum

cc @Dylan-DPC

@rustbot label T-rustdoc

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 30, 2022
@Dylan-DPC
Copy link
Member

Dylan-DPC commented Sep 1, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 1, 2022

📌 Commit 8410df3 has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2022
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Sep 1, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 1, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Sep 1, 2022

📌 Commit 8410df3 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 1, 2022
@matthiaskrgr
Rollup merge of rust-lang#101215 - est31:rustdoc_version_placeholder,…
6a4f64c 
… r=Mark-Simulacrum

Also replace the version placeholder in rustc_attr

Replace the version placeholder with the current version in the rustc_attr crate too so that users won't see the placeholder but instead the explicit version. This especially fixes the bug for rustdoc not showing it but instead the placeholder.

Originally reported [here](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/libs.20stabilization.20placeholder/near/296057188).

cc rust-lang#100591

![Screenshot_20220830_233727](https://user-images.githubusercontent.com/8872119/187548079-6207776b-4481-4351-afff-607f5b3fe03a.png)
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 1, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 1, 2022
@matthiaskrgr
Rollup merge of rust-lang#101215 - est31:rustdoc_version_placeholder,…
a80ef27 
… r=Mark-Simulacrum

Also replace the version placeholder in rustc_attr

Replace the version placeholder with the current version in the rustc_attr crate too so that users won't see the placeholder but instead the explicit version. This especially fixes the bug for rustdoc not showing it but instead the placeholder.

Originally reported [here](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/libs.20stabilization.20placeholder/near/296057188).

cc rust-lang#100591

![Screenshot_20220830_233727](https://user-images.githubusercontent.com/8872119/187548079-6207776b-4481-4351-afff-607f5b3fe03a.png)
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 1, 2022
Closed
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Sep 1, 2022

@bors r- failed in a rollup:
#101290 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2022
@est31
Also replace the version placeholder in rustc_attr
0c4ec5d 
This fixes rustdoc not showing the current version as stabilization version
for recently stabilized lang features.
@est31 est31 force-pushed the rustdoc_version_placeholder branch from 8410df3 to 0c4ec5d Compare September 1, 2022 23:47
@est31
Copy link
Member Author

est31 commented Sep 1, 2022

@rustbot ready (although I haven't tested it yet)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 1, 2022
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Sep 2, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 2, 2022

📌 Commit 0c4ec5d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 2, 2022
@matthiaskrgr
Rollup merge of rust-lang#101215 - est31:rustdoc_version_placeholder,…
311a1e9 
… r=Mark-Simulacrum

Also replace the version placeholder in rustc_attr

Replace the version placeholder with the current version in the rustc_attr crate too so that users won't see the placeholder but instead the explicit version. This especially fixes the bug for rustdoc not showing it but instead the placeholder.

Originally reported [here](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/libs.20stabilization.20placeholder/near/296057188).

cc rust-lang#100591

![Screenshot_20220830_233727](https://user-images.githubusercontent.com/8872119/187548079-6207776b-4481-4351-afff-607f5b3fe03a.png)
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 2, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 2, 2022
@Dylan-DPC
Rollup merge of rust-lang#101215 - est31:rustdoc_version_placeholder,…
9b6bf08 
… r=Mark-Simulacrum

Also replace the version placeholder in rustc_attr

Replace the version placeholder with the current version in the rustc_attr crate too so that users won't see the placeholder but instead the explicit version. This especially fixes the bug for rustdoc not showing it but instead the placeholder.

Originally reported [here](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/libs.20stabilization.20placeholder/near/296057188).

cc rust-lang#100591

![Screenshot_20220830_233727](https://user-images.githubusercontent.com/8872119/187548079-6207776b-4481-4351-afff-607f5b3fe03a.png)
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 2, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 2, 2022
@Dylan-DPC
Rollup merge of rust-lang#101215 - est31:rustdoc_version_placeholder,…
1a815f6 
… r=Mark-Simulacrum

Also replace the version placeholder in rustc_attr

Replace the version placeholder with the current version in the rustc_attr crate too so that users won't see the placeholder but instead the explicit version. This especially fixes the bug for rustdoc not showing it but instead the placeholder.

Originally reported [here](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/libs.20stabilization.20placeholder/near/296057188).

cc rust-lang#100591

![Screenshot_20220830_233727](https://user-images.githubusercontent.com/8872119/187548079-6207776b-4481-4351-afff-607f5b3fe03a.png)
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 2, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 2, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 2, 2022
@bors
Auto merge of rust-lang#101333 - matthiaskrgr:rollup-qpf1otj, r=matth…
9ba169a 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#100121 (Try normalizing types without RevealAll in ParamEnv in MIR validation)
 - rust-lang#100200 (Change implementation of `-Z gcc-ld` and `lld-wrapper` again)
 - rust-lang#100814 ( Porting 'compiler/rustc_trait_selection' to translatable diagnostics - Part 1)
 - rust-lang#101215 (Also replace the version placeholder in rustc_attr)
 - rust-lang#101260 (Use `FILE_ATTRIBUTE_TAG_INFO` to get reparse tag)
 - rust-lang#101323 (Remove unused .toggle-label CSS rule)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5a23efd into rust-lang:master Sep 2, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 2, 2022
@est31 est31 mentioned this pull request Sep 13, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 14, 2022
@Dylan-DPC
Rollup merge of rust-lang#101772 - est31:replace_placeholder_diagnost…
94bc08d 
…ics, r=jackh726

Also replace the placeholder for the stable_features lint

Follow up of  rust-lang#101215 and rust-lang#100591 .

Fixes rust-lang#101766
@est31 est31 mentioned this pull request May 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

8 participants

@est31 @rust-highfive @Dylan-DPC @bors @Mark-Simulacrum @matthiaskrgr @lcnr @rustbot