Avoid infinite recursion on error case in get_path_res.#101513
Closed
nnethercote wants to merge 1 commit intorust-lang:masterfrom
Closed
Avoid infinite recursion on error case in get_path_res.#101513nnethercote wants to merge 1 commit intorust-lang:masterfrom
get_path_res.#101513nnethercote wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
nnethercote
force-pushed
the
fix-101505
branch
from
7588faf to
80845be
Compare
Member
|
Could we move this forward somehow? |
Contributor
|
Thanks for the ping. I took the opportunity to add a sanity check to HIR indexing to detect this sort of bug earlier in #101688. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 12, 2022
…henkov Assert that HIR nodes are not their own parent. Fixes rust-lang#101505. Replaces rust-lang#101513 r? `@petrochenkov` `@nnethercote`
Contributor
Author
|
Fixed in a better way by #101688. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101505.
r? @petrochenkov