[WIP] Migrate rustc_ast_passes diagnostics to SessionDiagnostic and translatable messages (second part)

[finalchild]

Second (and hopefully last) PR migrating rustc_ast_passes to SessionDiagnostics.

@rustbot label +A-translation

[rust-highfive]

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

[finalchild]

I don't understand how the CI job failed.

error[E0599]: no variant or associated item named `Type` found for enum `ParamKindOrd` in the current scope
   --> compiler/rustc_errors/src/diagnostic.rs:173:32
    |
173 |             ast::ParamKindOrd::Type => "type",
    |                                ^^^^ variant or associated item not found in `ParamKindOrd`

error[E0599]: no variant or associated item named `Const` found for enum `ParamKindOrd` in the current scope
   --> compiler/rustc_errors/src/diagnostic.rs:174:32
    |
174 |             ast::ParamKindOrd::Const => "const",
    |                                ^^^^^ variant or associated item not found in `ParamKindOrd`

error[E0599]: no variant or associated item named `Infer` found for enum `ParamKindOrd` in the current scope
   --> compiler/rustc_errors/src/diagnostic.rs:175:32
    |
175 |             ast::ParamKindOrd::Infer => "infer",
    |                                ^^^^^ variant or associated item not found in `ParamKindOrd`

Maybe some kind of incremental build issue? Is there a way to clean the cache of CI?

[RanolP]

I don't understand how the CI job failed.

error[E0599]: no variant or associated item named `Type` found for enum `ParamKindOrd` in the current scope
   --> compiler/rustc_errors/src/diagnostic.rs:173:32
    |
173 |             ast::ParamKindOrd::Type => "type",
    |                                ^^^^ variant or associated item not found in `ParamKindOrd`

error[E0599]: no variant or associated item named `Const` found for enum `ParamKindOrd` in the current scope
   --> compiler/rustc_errors/src/diagnostic.rs:174:32
    |
174 |             ast::ParamKindOrd::Const => "const",
    |                                ^^^^^ variant or associated item not found in `ParamKindOrd`

error[E0599]: no variant or associated item named `Infer` found for enum `ParamKindOrd` in the current scope
   --> compiler/rustc_errors/src/diagnostic.rs:175:32
    |
175 |             ast::ParamKindOrd::Infer => "infer",
    |                                ^^^^^ variant or associated item not found in `ParamKindOrd`

Maybe some kind of incremental build issue? Is there a way to clean the cache of CI?

I think ae49732 caused the error on your code. The commit has changed the ParamKindOrd, you're trying to impl, from master. Therefore, you'll need to follow up on those changes.

[lcnr]

r? @davidtwco

[davidtwco]

Are you looking to land this or still working on it?

[finalchild]

There's one more file to migrate!

[davidtwco]

Apologies for the delay in reviewing.

[davidtwco]

Can't the derive be used for this?

[davidtwco]

Can the derive be used for this?

[davidtwco]

Can these be split into multiple Fluent messages to avoid pattern matching on strings?

[bors]

☔ The latest upstream changes (presumably #104507) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #104754) made this pull request unmergeable. Please resolve the merge conflicts.