change AccessLevels representation by Bryanskiy · Pull Request #101713 · rust-lang/rust

Bryanskiy · 2022-09-12T08:30:37Z

Part of RFC (#48054). This patch implements effective visibility table with basic methods and change AccessLevels table representation according to it.

r? @petrochenkov

petrochenkov · 2022-09-12T10:51:45Z

Could you include the testing stuff from #100962 (src/test/ui/privacy/access_levels.rs and its compiler implementation) into this PR?

compiler/rustc_middle/src/middle/privacy.rs

src/librustdoc/core.rs

compiler/rustc_resolve/src/access_levels.rs

compiler/rustc_middle/src/middle/privacy.rs

src/test/ui/privacy/access_levels.rs

compiler/rustc_privacy/src/lib.rs

compiler/rustc_middle/src/middle/privacy.rs

petrochenkov · 2022-09-13T13:55:17Z

Possible improvement for the borrow checker problem - petrochenkov@32fd8f7.

rustbot · 2022-09-13T17:40:43Z

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

Bryanskiy · 2022-09-13T18:34:55Z

@rustbot ready

compiler/rustc_privacy/src/lib.rs

compiler/rustc_passes/src/dead.rs

compiler/rustc_passes/src/reachable.rs

compiler/rustc_middle/src/middle/privacy.rs

compiler/rustc_passes/src/dead.rs

compiler/rustc_passes/src/reachable.rs

petrochenkov · 2022-09-14T14:55:03Z

r=me after applying the final cleanups and squashing commits.

Bryanskiy · 2022-09-14T15:12:01Z

@rustbot ready

petrochenkov · 2022-09-14T15:16:56Z

@bors r+

bors · 2022-09-14T15:16:58Z

📌 Commit d7b9221 has been approved by petrochenkov

It is now in the queue for this repository.

…nkov change AccessLevels representation Part of RFC (rust-lang#48054). This patch implements effective visibility table with basic methods and change AccessLevels table representation according to it. r? `@petrochenkov`

…nkov change AccessLevels representation Part of RFC (rust-lang#48054). This patch implements effective visibility table with basic methods and change AccessLevels table representation according to it. r? ``@petrochenkov``

bors · 2022-09-16T02:43:55Z

⌛ Testing commit d7b9221 with merge 30567c4f2b19c6c6ee49dc28f20116adb5221ee5...

bors · 2022-09-16T06:58:55Z

💥 Test timed out

rust-log-analyzer · 2022-09-16T07:28:12Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

petrochenkov · 2022-09-16T11:37:56Z

Timeout.
@bors retry

…nkov change AccessLevels representation Part of RFC (rust-lang#48054). This patch implements effective visibility table with basic methods and change AccessLevels table representation according to it. r? `@petrochenkov`

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#101093 (Initial version of 1.64 release notes) - rust-lang#101713 (change AccessLevels representation) - rust-lang#101821 (Bump Unicode to version 15.0.0, regenerate tables) - rust-lang#101826 (Enforce "joined()" and "joined_with_noop()" test) - rust-lang#101835 (Allow using vendoring when running bootstrap from outside the source root) - rust-lang#101942 (Revert "Copy stage0 binaries into stage0-sysroot") - rust-lang#101943 (rustdoc: remove unused CSS `.non-exhaustive { margin-bottom }`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…nkov Populate effective visibilities in 'rustc_resolve' Next part of RFC rust-lang#48054. previous: rust-lang#101713 `@rustbot` author r? `@petrochenkov`

Populate effective visibilities in 'rustc_resolve' Next part of RFC rust-lang/rust#48054. previous: rust-lang/rust#101713 `@rustbot` author r? `@petrochenkov`

rust-highfive assigned petrochenkov Sep 12, 2022

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 12, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 12, 2022

This comment has been minimized.

Sign in to view

petrochenkov reviewed Sep 12, 2022

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2022

This comment was marked as resolved.

Sign in to view

petrochenkov reviewed Sep 13, 2022

View reviewed changes

rustbot added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Sep 13, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2022

petrochenkov reviewed Sep 14, 2022

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2022

Bryanskiy force-pushed the AccessLevels branch from ff946d3 to dd8c214 Compare September 14, 2022 14:37

petrochenkov reviewed Sep 14, 2022

View reviewed changes

compiler/rustc_middle/src/middle/privacy.rs Outdated Show resolved Hide resolved

compiler/rustc_passes/src/dead.rs Outdated Show resolved Hide resolved

compiler/rustc_passes/src/reachable.rs Outdated Show resolved Hide resolved

change AccessLevels representation

d7b9221

Bryanskiy force-pushed the AccessLevels branch from dd8c214 to d7b9221 Compare September 14, 2022 15:11

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 14, 2022

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 14, 2022

Dylan-DPC mentioned this pull request Sep 15, 2022

Rollup of 6 pull requests #101850

Closed

Dylan-DPC mentioned this pull request Sep 15, 2022

Rollup of 6 pull requests #101853

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 16, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2022

GuillaumeGomez mentioned this pull request Sep 16, 2022

Rollup of 7 pull requests #101910

Closed

matthiaskrgr mentioned this pull request Sep 17, 2022

Rollup of 7 pull requests #101949

Merged

bors merged commit a6b34cd into rust-lang:master Sep 18, 2022

rustbot added this to the 1.66.0 milestone Sep 18, 2022

Bryanskiy mentioned this pull request Sep 19, 2022

Populate effective visibilities in 'rustc_resolve' #102026

Merged

Bryanskiy deleted the AccessLevels branch May 18, 2023 12:53

Uh oh!

Conversation

Bryanskiy commented Sep 12, 2022

Uh oh!

This comment has been minimized.

petrochenkov commented Sep 12, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Sep 13, 2022

Uh oh!

rustbot commented Sep 13, 2022

Uh oh!

Bryanskiy commented Sep 13, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Sep 14, 2022

Uh oh!

Bryanskiy commented Sep 14, 2022

Uh oh!

petrochenkov commented Sep 14, 2022

Uh oh!

bors commented Sep 14, 2022

Uh oh!

bors commented Sep 16, 2022

Uh oh!

bors commented Sep 16, 2022

Uh oh!

rust-log-analyzer commented Sep 16, 2022

Uh oh!

petrochenkov commented Sep 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants