Closed
Conversation
And into `AttrAnnotatedTokenTree::Token`. PR rust-lang#99887 did the same thing for `TokenStream`.
These two type names are long and have long matching prefixes. I find
them hard to read, especially in combinations like
`AttrAnnotatedTokenStream::new(vec![AttrAnnotatedTokenTree::Token(..)])`.
This commit renames them as `AttrToken{Stream,Tree}`.
The `AttrTokenStream` is always immediately turned into a `TokenStream`.
`To` is better than `Create` for indicating that this is a non-consuming conversion, rather than creating something out of nothing. And the addition of `Attr` is because the current names makes them sound like they relate to `TokenStream`, but really they relate to `AttrTokenStream`.
This fixes the typo `&[u8, _]` -> `&[u8; _]`
…rochenkov Streamline `AttrAnnotatedTokenStream` r? ``@petrochenkov``
…-obk Avoid `Iterator::last` Adapters like `Filter` and `Map` use the default implementation of `Iterator::last` which is not short-circuiting (and so does `core::str::Split`). The predicate function will be run for every single item of the underlying iterator. I hope that removing those calls to `last` results in slight performance improvements.
…avidtwco A `SubstitutionPart` is not considered a deletion if it replaces nothing with nothing Fixes rust-lang#101689
Fix typo in concat_bytes documentation This fixes the typo `&[u8, _]` -> `&[u8; _]`
…-sidebar-toggle, r=GuillaumeGomez rustdoc: remove redundant CSS `#source-sidebar, #sidebar-toggle` These two elements are always nested below `<nav class="sidebar">`, and will inherit the font from their parent. These selectors were added in 93520d2, and became redundant in 07e3f99 when the source sidebar elements became nested below `nav.sidebar`.
rustbot
added
T-compiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
AttrAnnotatedTokenStream#101602 (StreamlineAttrAnnotatedTokenStream)Iterator::last#101690 (AvoidIterator::last)SubstitutionPartis not considered a deletion if it replaces nothing with nothing #101700 (ASubstitutionPartis not considered a deletion if it replaces nothing with nothing)#source-sidebar, #sidebar-toggle#101748 (rustdoc: remove redundant CSS#source-sidebar, #sidebar-toggle)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup