Migrating rustc_infer to session diagnostics (part 3)#101936
Merged
bors merged 16 commits intorust-lang:masterfrom Jan 8, 2023
Merged
Migrating rustc_infer to session diagnostics (part 3)#101936bors merged 16 commits intorust-lang:masterfrom
bors merged 16 commits intorust-lang:masterfrom
Conversation
rustbot
added
A-translation
rust-highfive
added
the
S-waiting-on-review
IntQuant
changed the title
Collaborator
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
This comment was marked as resolved.
This comment was marked as resolved.
IntQuant
force-pushed
the
issue-100717-infer-4
branch
from
448bf9a to
88997de
Compare
davidtwco
reviewed
Sep 22, 2022
Contributor
|
r? @davidtwco |
IntQuant
force-pushed
the
issue-100717-infer-4
branch
from
1a41b5d to
3b691b2
Compare
davidtwco
reviewed
Oct 4, 2022
davidtwco
reviewed
Oct 4, 2022
IntQuant
force-pushed
the
issue-100717-infer-4
branch
from
3b691b2 to
feb9d4f
Compare
Member
|
Hi, I've seen you changed some diagnostic structs in your PR. After #103345, the way we refer to fluent messages changed. They are now in a flat namespace with the same identifier as in the fluent file. For example, |
IntQuant
force-pushed
the
issue-100717-infer-4
branch
from
96f9f8f to
bb9743a
Compare
davidtwco
requested changes
Nov 3, 2022
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
Apologies for the delay in giving this another review.
compiler/rustc_infer/src/infer/error_reporting/nice_region_error/named_anon_conflict.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_infer/src/infer/error_reporting/nice_region_error/placeholder_error.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_infer/src/infer/error_reporting/nice_region_error/placeholder_error.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_infer/src/infer/error_reporting/nice_region_error/placeholder_error.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_infer/src/infer/error_reporting/nice_region_error/static_impl_trait.rs
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
IntQuant
force-pushed
the
issue-100717-infer-4
branch
from
306ec64 to
fc6d506
Compare
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
IntQuant
force-pushed
the
issue-100717-infer-4
branch
2 times, most recently
from
9b1ef24 to
88ac4c0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
IntQuant
force-pushed
the
issue-100717-infer-4
branch
from
88ac4c0 to
ef9646e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
IntQuant
force-pushed
the
issue-100717-infer-4
branch
from
248c2ac to
0c50e1f
Compare
Member
|
Sorry for the delay in getting back to this, thanks to @compiler-errors for picking up the slack. @bors r=compiler-errors |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 7, 2023
…ompiler-errors Migrating rustc_infer to session diagnostics (part 3) `@rustbot` label +A-translation r? rust-lang/diagnostics cc rust-lang#100717 Seems like a part of static_impl_trait.rs emits suggestions in a loop, and note.rs needs to have two instances of the same subdiagnostic, so these will need to wait until we have eager translation/list support. Other than that, there is only error_reporting/mod.rs left to migrate.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 7, 2023
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#101936 (Migrating rustc_infer to session diagnostics (part 3)) - rust-lang#104081 (PhantomData layout guarantees) - rust-lang#104543 (Migrate `codegen_ssa` to diagnostics structs - [Part 3]) - rust-lang#105128 (Add O(1) `Vec -> VecDeque` conversion guarantee) - rust-lang#105517 (Fix process-panic-after-fork.rs to pass on newer versions of Android.) - rust-lang#105859 (Point out span where we could introduce higher-ranked lifetime) - rust-lang#106509 (Detect closures assigned to binding in block) - rust-lang#106553 (docs: make `HashSet::retain` doctest more clear) - rust-lang#106556 (rustdoc: remove no-op mobile CSS `.content { margin-left: 0 }`) - rust-lang#106564 (Change to immutable borrow when cloning element of RepeatN) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rustbot label +A-translation
r? rust-lang/diagnostics
cc #100717
Seems like a part of static_impl_trait.rs emits suggestions in a loop, and note.rs needs to have two instances of the same subdiagnostic, so these will need to wait until we have eager translation/list support.
Other than that, there is only error_reporting/mod.rs left to migrate.