Migrate rustc_passes diagnostics by CleanCut · Pull Request #102110 · rust-lang/rust

CleanCut · 2022-09-21T17:49:36Z

Picks up abandoned work from #100870

I would like to do this collaboratively, as there is a lot of work! Here's the process:

Comment below that you are willing to help and I will add you as a collaborator to my rust fork (that gives you write access)
Indicate which file/task you would like to work on (so we don't duplicate work) from the list below
Do the work, push up a commit, comment that you're done with that file/task
Repeat until done 😄

Files to Migrate (in `compiler/rustc_passes/src/`)

Tasks

Rebase on current master @CleanCut
Review work from the earlier PR and make sure it all looks good
- compiler/rustc_error_messages/locales/en-US/passes.ftl @CleanCut
- compiler/rustc_passes/src/check_attr.rs @CleanCut
- compiler/rustc_passes/src/errors.rs @CleanCut
- compiler/rustc_passes/src/lang_items.rs @CleanCut
- compiler/rustc_passes/src/lib.rs @CleanCut
- compiler/rustc_passes/src/weak_lang_items.rs @CleanCut

rust-highfive · 2022-09-21T17:49:40Z

r? @eholk

(rust-highfive has picked a reviewer for you, use r? to override)

diegooliveira · 2022-09-21T23:30:11Z

I was working on some files from the rustc_passes on this #101815.

CleanCut · 2022-09-22T04:02:03Z

@diegooliveira Great! Should we merge those changes into this PR? Do you want to collaborate here?

CleanCut · 2022-09-23T16:58:15Z

I rebased on master again. There were lots of little conflicts to resolve.

CleanCut · 2022-09-28T20:15:24Z

Rebased again to resolve new conflicts.

CleanCut · 2022-10-09T20:27:25Z

@davidtwco Ready for a re-review.

davidtwco

One nit then r=me

compiler/rustc_passes/src/diagnostic_items.rs

davidtwco · 2022-10-11T07:45:15Z

@bors r+

bors · 2022-10-11T07:45:17Z

📌 Commit 5ef1c03 has been approved by davidtwco

It is now in the queue for this repository.

…nostics, r=davidtwco Migrate rustc_passes diagnostics Picks up abandoned work from rust-lang#100870 I would like to do this collaboratively, as there is a lot of work! Here's the process: - Comment below that you are willing to help and I will add you as a collaborator to my `rust` fork (that gives you write access) - Indicate which file/task you would like to work on (so we don't duplicate work) from the list below - Do the work, push up a commit, comment that you're done with that file/task - Repeat until done 😄 ### Files to Migrate (in `compiler/rustc_passes/src/`) - [x] check_attr.rs `@CleanCut` - [x] check_const.rs `@CleanCut` - [x] dead.rs `@CleanCut` - [x] debugger_visualizer.rs `@CleanCut` - [x] diagnostic_items.rs `@CleanCut` - [x] entry.rs `@CleanCut` - [x] lang_items.rs `@CleanCut` - [x] layout_test.rs `@CleanCut` - [x] lib_features.rs `@CleanCut` - [x] ~liveness.rs~ `@CleanCut` Nothing to do - [x] loops.rs `@CleanCut` - [x] naked_functions.rs `@CleanCut` - [x] stability.rs `@CleanCut` - [x] weak_lang_items.rs `@CleanCut` ### Tasks - [x] Rebase on current `master` `@CleanCut` - [x] Review work from [the earlier PR](rust-lang#100870) and make sure it all looks good - [x] compiler/rustc_error_messages/locales/en-US/passes.ftl `@CleanCut` - [x] compiler/rustc_passes/src/check_attr.rs `@CleanCut` - [x] compiler/rustc_passes/src/errors.rs `@CleanCut` - [x] compiler/rustc_passes/src/lang_items.rs `@CleanCut` - [x] compiler/rustc_passes/src/lib.rs `@CleanCut` - [x] compiler/rustc_passes/src/weak_lang_items.rs `@CleanCut`

Rollup of 8 pull requests Successful merges: - rust-lang#102110 (Migrate rustc_passes diagnostics) - rust-lang#102187 (Use correct location for type tests in promoted constants) - rust-lang#102239 (Move style guide to rust-lang/rust) - rust-lang#102578 (Panic for invalid arguments of `{integer primitive}::ilog{,2,10}` in all modes) - rust-lang#102811 (Use memset to initialize readbuf) - rust-lang#102890 (Check representability in adt_sized_constraint) - rust-lang#102913 (unify `IsPattern` and `IsImport` enum in `show_candidates`) - rust-lang#102924 (rustdoc: remove unused classes from sidebar links) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned eholk Sep 21, 2022

rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2022

CleanCut changed the title ~~Migrate rustc passes diagnostics~~ Migrate rustc_passes diagnostics Sep 21, 2022

This was referenced Sep 21, 2022

Diagnostic Translation #100717

Open

Migrate rustc_passes diagnostics #100870

Closed

CleanCut force-pushed the migrate_rustc_passes_diagnostics branch from fb6d205 to b2769b3 Compare September 21, 2022 18:43

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

CleanCut force-pushed the migrate_rustc_passes_diagnostics branch from 5649131 to 4a5d9fc Compare September 23, 2022 16:57

CleanCut force-pushed the migrate_rustc_passes_diagnostics branch from 4a5d9fc to 50c878d Compare September 23, 2022 17:42