Resolve async fn signature even without body (e.g., in trait)#102161
Merged
bors merged 3 commits intorust-lang:masterfrom Sep 25, 2022
Merged
Resolve async fn signature even without body (e.g., in trait)#102161bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
T-compiler
Contributor
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
compiler-errors
added
the
F-return_position_impl_trait_in_trait
tmandry
reviewed
Sep 22, 2022
tmandry
reviewed
Sep 22, 2022
Member
|
r=me after comments |
Contributor
Author
|
Ugh, actually this passes now and might not after the changes: fn main() {}
trait Foo {
fn fn_with_type_named_same_as_local_in_param(b: i32, b: i32);
}Let me see if I can avoid this. |
compiler-errors
force-pushed
the
issue-102138
branch
2 times, most recently
from
3ba9fab to
271a068
Compare
Contributor
Author
|
Okay, fixed that bug by just doing the only part of resolve that we need for AFIT. |
Member
|
r? @tmandry |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 271a0680197e08405c67dd0b4d4bac87ea9a28bc has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
Member
Actually, want to add a test for this? (and r=me) Not sure it's the behavior I would want, but it's too late for that anyway :) @bors r- |
bors
added
S-waiting-on-author
compiler-errors
force-pushed
the
issue-102138
branch
from
5029212 to
e87fcc0
Compare
Contributor
Author
|
@bors r=tmandry |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 24, 2022
…andry Resolve async fn signature even without body (e.g., in trait) Fixes rust-lang#102138 This "bail if no body" behavior was introduced in rust-lang#69539 to fix rust-lang#69401, but that ICE does not reproduce any more. The error message changes a bit, but that's all, and I don't think it's a particularly diagnostic bad regression.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2022
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#102016 (implied_bounds: deal with inference vars) - rust-lang#102161 (Resolve async fn signature even without body (e.g., in trait)) - rust-lang#102216 (rustdoc: Stabilize --diagnostic-width) - rust-lang#102240 (rustdoc: remove unused CSS `#main-content > .line-numbers`) - rust-lang#102242 (rustdoc: remove unused CSS `.summary`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102138
This "bail if no body" behavior was introduced in #69539 to fix #69401, but that ICE does not reproduce any more. The error message changes a bit, but that's all, and I don't think it's a particularly diagnostic bad regression.