Closed
Conversation
The build script for `compiler_builtins` doesn't support cross-compilation. I tried fixing it, but the cc crate itself doesn't appear to support cross-compiling to windows either unless you use the -gnu toolchain: ``` error occurred: Failed to find tool. Is `lib.exe` installed? ``` Rather than trying to fix it or special-case the platforms without bugs, make it opt-in instead of automatic.
…tins, r=Mark-Simulacrum Make the `c` feature for `compiler-builtins` an explicit opt-in Its build script doesn't support cross-compilation. I tried fixing it, but the cc crate itself doesn't appear to support cross-compiling to windows either unless you use the -gnu toolchain: ``` error occurred: Failed to find tool. Is `lib.exe` installed? ``` Fixes rust-lang#101172.
…pls, r=lcnr Allow more `!Copy` impls You can already implement `!Copy` for a lot of types (with `#![feature(negative_impls)]`). However, before this PR you could not implement `!Copy` for ADTs whose fields don't implement `Copy` which didn't make any sense. Further, you couldn't implement `!Copy` for types impl'ing `Drop` (equally nonsensical). `@rustbot` label T-types F-negative_impls Fixes rust-lang#101836. r? types
…st, r=Mark-Simulacrum Add regression test This adds a regression test for issue rust-lang#100878. Closes rust-lang#100878.
…gfei2009 Fix lint scoping for let-else. The scoping for let-else is inconsistent with HIR nesting. This creates cases, in `ui/let-else/let-else-allow-unused.rs` for instance, where an `allow` lint attribute does not apply to the bindings created by `let-else`. This PR is an attempt to correct this. As there is no lint that currently relies on this, the test for this behaviour is rust-lang#101500. cc `@dingxiangfei2009` as you filed rust-lang#101894
…dead Allow `~const` bounds on non-const functions Makes the behavior of bound of trait-associated functions and non-associated functions consistent.
…ock-item, r=davidtwco Recover some items that expect braces and don't take semicolons Fixes rust-lang#102262
rustbot
added
T-bootstrap
Member
Author
|
@bors r+ p=6 rollup=never |
Collaborator
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 592e0e0 with merge 25f456cac285133fd6436c5fba908492e8acbde5... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
davidtwco
removed
the
A-translation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
cfeature forcompiler-builtinsan explicit opt-in #101833 (Make thecfeature forcompiler-builtinsan explicit opt-in)!Copyimpls #101875 (Allow more!Copyimpls)~constbounds on non-const functions #102273 (Allow~constbounds on non-const functions)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup