Add a niche to `Duration`, unix `SystemTime`, and non-apple `Instant` by beetrees · Pull Request #102368 · rust-lang/rust

beetrees · 2022-09-27T18:09:44Z

As the nanoseconds fields is always between 0 and (NANOS_PER_SEC - 1) inclusive, use the rustc_layout_scalar_valid_range attributes to create a niche in the nanosecond field of Duration and Timespec (which is used to implement unix SystemTime and non-apple unix Instant; windows Instant is implemented with Duration and therefore will also benefit). This change has the benefit of making Option<T> the same size as T for the previously mentioned types. Also shrinks the nanoseconds field of Timespec to a u32 as nanoseconds do not need the extra range of an i64, shrinking Timespec by 4 bytes on 32-bit platforms.

r? @joshtriplett

rust-highfive · 2022-09-27T18:09:47Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

rustbot · 2022-09-27T18:09:47Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

library/core/src/time.rs

joshtriplett · 2022-09-28T10:27:57Z

r=me with repr(transparent) added as @CryZe requested. Nice work!

beetrees · 2022-09-28T12:14:30Z

@joshtriplett #[repr(transparent)] added as requested.

joshtriplett · 2022-09-28T12:50:23Z

@bors r+ rollup

bors · 2022-09-28T12:50:25Z

📌 Commit b9b969a has been approved by joshtriplett

It is now in the queue for this repository.

Add a niche to `Duration`, unix `SystemTime`, and non-apple `Instant` As the nanoseconds fields is always between `0` and `(NANOS_PER_SEC - 1)` inclusive, use the `rustc_layout_scalar_valid_range` attributes to create a niche in the nanosecond field of `Duration` and `Timespec` (which is used to implement unix `SystemTime` and non-apple unix `Instant`; windows `Instant` is implemented with `Duration` and therefore will also benefit). This change has the benefit of making `Option<T>` the same size as `T` for the previously mentioned types. Also shrinks the nanoseconds field of `Timespec` to a `u32` as nanoseconds do not need the extra range of an `i64`, shrinking `Timespec` by 4 bytes on 32-bit platforms. r? `@joshtriplett`

Dylan-DPC · 2022-09-28T15:08:51Z

failed in rollup

@bors r-

joshtriplett · 2022-09-28T22:29:45Z

@bors r+ rollup

bors · 2022-09-28T22:29:47Z

📌 Commit a913277 has been approved by joshtriplett

It is now in the queue for this repository.

CryZe · 2022-09-28T22:29:49Z

The debugger visualization / natvis for Windows wasn't adjusted to handle the new struct.

Add a niche to `Duration`, unix `SystemTime`, and non-apple `Instant` As the nanoseconds fields is always between `0` and `(NANOS_PER_SEC - 1)` inclusive, use the `rustc_layout_scalar_valid_range` attributes to create a niche in the nanosecond field of `Duration` and `Timespec` (which is used to implement unix `SystemTime` and non-apple unix `Instant`; windows `Instant` is implemented with `Duration` and therefore will also benefit). This change has the benefit of making `Option<T>` the same size as `T` for the previously mentioned types. Also shrinks the nanoseconds field of `Timespec` to a `u32` as nanoseconds do not need the extra range of an `i64`, shrinking `Timespec` by 4 bytes on 32-bit platforms. r? `@joshtriplett`

Add a niche to `Duration`, unix `SystemTime`, and non-apple `Instant` As the nanoseconds fields is always between `0` and `(NANOS_PER_SEC - 1)` inclusive, use the `rustc_layout_scalar_valid_range` attributes to create a niche in the nanosecond field of `Duration` and `Timespec` (which is used to implement unix `SystemTime` and non-apple unix `Instant`; windows `Instant` is implemented with `Duration` and therefore will also benefit). This change has the benefit of making `Option<T>` the same size as `T` for the previously mentioned types. Also shrinks the nanoseconds field of `Timespec` to a `u32` as nanoseconds do not need the extra range of an `i64`, shrinking `Timespec` by 4 bytes on 32-bit platforms. r? ``@joshtriplett``

Rollup of 8 pull requests Successful merges: - rust-lang#98368 (Make `std::os::fd` public.) - rust-lang#102085 (Code refactoring smart_resolve_report_errors) - rust-lang#102351 (Improve E0585 help) - rust-lang#102368 (Add a niche to `Duration`, unix `SystemTime`, and non-apple `Instant`) - rust-lang#102393 (Add regression test for issue 94923) - rust-lang#102399 (Account for use of index-based lifetime names in print of binder) - rust-lang#102416 (remove FIXME, improve documentation) - rust-lang#102433 (env::temp_dir: fix a typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned joshtriplett Sep 27, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 27, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 27, 2022

beetrees mentioned this pull request Sep 27, 2022

Improve File::set_times error handling #101675

Merged

CryZe reviewed Sep 28, 2022

View reviewed changes

library/core/src/time.rs Outdated Show resolved Hide resolved

beetrees force-pushed the nano-niche branch from 68459a8 to b9b969a Compare September 28, 2022 11:38

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2022

Dylan-DPC mentioned this pull request Sep 28, 2022

Rollup of 6 pull requests #102407

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 28, 2022

Add a niche to Duration, unix SystemTime, and non-apple Instant

a913277

beetrees force-pushed the nano-niche branch from b9b969a to a913277 Compare September 28, 2022 17:24

beetrees requested a review from joshtriplett September 28, 2022 17:57

joshtriplett approved these changes Sep 28, 2022

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 28, 2022

JohnTitor mentioned this pull request Sep 29, 2022

Rollup of 11 pull requests #102448

Closed

JohnTitor mentioned this pull request Sep 29, 2022

Rollup of 10 pull requests #102449

Closed

JohnTitor mentioned this pull request Sep 29, 2022

Rollup of 8 pull requests #102450

Merged

bors merged commit 8e4869e into rust-lang:master Sep 29, 2022

rustbot added this to the 1.66.0 milestone Sep 29, 2022

wangrunji0408 mentioned this pull request Oct 28, 2022

fix(time): fix panic cause by std internal structure change madsim-rs/madsim#88

Merged

beetrees deleted the nano-niche branch March 30, 2023 14:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add a niche to `Duration`, unix `SystemTime`, and non-apple `Instant`#102368

Add a niche to `Duration`, unix `SystemTime`, and non-apple `Instant`#102368
bors merged 1 commit intorust-lang:masterfrom
beetrees:nano-niche

beetrees commented Sep 27, 2022

Uh oh!

rust-highfive commented Sep 27, 2022

Uh oh!

rustbot commented Sep 27, 2022

Uh oh!

Uh oh!

joshtriplett commented Sep 28, 2022

Uh oh!

beetrees commented Sep 28, 2022

Uh oh!

joshtriplett commented Sep 28, 2022

Uh oh!

bors commented Sep 28, 2022

Uh oh!

Dylan-DPC commented Sep 28, 2022

Uh oh!

joshtriplett commented Sep 28, 2022

Uh oh!

bors commented Sep 28, 2022

Uh oh!

CryZe commented Sep 28, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

beetrees commented Sep 27, 2022

Uh oh!

rust-highfive commented Sep 27, 2022

Uh oh!

rustbot commented Sep 27, 2022

Uh oh!

Uh oh!

joshtriplett commented Sep 28, 2022

Uh oh!

beetrees commented Sep 28, 2022

Uh oh!

joshtriplett commented Sep 28, 2022

Uh oh!

bors commented Sep 28, 2022

Uh oh!

Dylan-DPC commented Sep 28, 2022

Uh oh!

joshtriplett commented Sep 28, 2022

Uh oh!

bors commented Sep 28, 2022

Uh oh!

CryZe commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

CryZe commented Sep 28, 2022 •

edited

Loading