Merged
Conversation
… to unwrap_or instead of suggesting calling it
This rule became irrelevant since c58246e made it so that the `summary::before` pseudo-element contains an SVG instead of text.
…se, r=compiler-errors Suggest unwrap_or_else when a closure is given Fixes rust-lang#102320 r? `@compiler-errors`
…earch-result, r=notriddle,jsha Migrate CSS theme for search results Part of rust-lang#98460. Just like rust-lang#102237, I unified theme to how the `ayu` handles this one: only one color for the background when search results are focused or hovered. You can test it [here](https://rustdoc.crud.net/imperio/migrate-css-theme-search-result/lib2/index.html?search=coo). cc `@jsha` r? `@notriddle` PS: The repetition in GUI tests is getting out of hand so I opened GuillaumeGomez/browser-UI-test#363 to think about adding possibility to declare functions so we can greatly improve this.
…vidtwco Delay evaluating lint primary message until after it would be suppressed Fixes rust-lang#102561 Fixes rust-lang#102572
…, r=GuillaumeGomez rustdoc: remove font family CSS on `.rustdoc-toggle summary::before` This rule became irrelevant since c58246e made it so that the `summary::before` pseudo-element contains an SVG instead of text.
Change the parameter name of From::from to `value`
The `From` trait is currently defined as:
```rust
pub trait From<T>: Sized {
fn from(_: T) -> Self;
}
```
The name of the argument is `_`. I am proposing to change it to `value`, ie.
```rust
pub trait From<T>: Sized {
fn from(value: T) -> Self;
}
```
This would be more consistent with the `TryFrom`, which looks like this:
```rust
pub trait TryFrom<T>: Sized {
type Error;
fn try_from(value: T) -> Result<Self, Self::Error>;
}
```
The reason for this proposal is twofold:
1. Consistency with the rest of the standard library. The `TryFrom` trait uses `value`, and no `From` implementation uses the default name (as it is quite useless).
2. When generating trait implementations with rust-analyzer/IntelliJ, the parameter name is copied, and it always has to be changed.
Optionally, another name like `x` could be used. I only propose `value` for consistency with `TryFrom`.
Changing parameter names is not a breaking change.
Note: this was originally posted as an internals thread [here](https://internals.rust-lang.org/t/change-the-argument-name-of-from-from/17480)
…ests, r=tmandry Ignore fuchsia on two compiler tests Adding `ignore-fuchsia` to two irrelevant compiler tests cc. `@djkoloski` r? `@tmandry`
…g, r=Aaron1011 Improve spans when splitting multi-char operator tokens for proc macros. When a two-char (or three-char) operator token is split into single-char operator tokens before being passed to a proc macro, the single-char tokens are given the original span of length two (or three). This PR gives them more accurate spans. r? `@Aaron1011` cc `@petrochenkov`
rustbot
added
T-compiler
Member
Author
|
@bors r+ rollup=never p=7 |
Collaborator
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: d9f8b4b985 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Oct 4, 2022
Collaborator
|
Finished benchmarking commit (f111209): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
.rustdoc-toggle summary::before#102624 (rustdoc: remove font family CSS on.rustdoc-toggle summary::before)value#102628 (Change the parameter name of From::from tovalue)Failed merges:
.into()when all other coercion suggestions fail #102496 (Suggest.into()when all other coercion suggestions fail)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup