Make test err annotations formatting uniform

[Rageking8]

Convert all test err annotation formatting to the style within rustc dev guide.

I have manually checked every single line of diff to ensure that no unwanted changes slip through. I excluded anything under src/tools. Thanks.

[rust-highfive]

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

[Mark-Simulacrum]

I am not sure this is worth doing - we parse both formats in compiletest, and either is readable, so normalizing them only adds a speed bump when adding new definitions (presuming we enforce it) without major benefit I think.

Can you say more about what motivated this PR?

[Rageking8]

I am not sure this is worth doing - we parse both formats in compiletest, and either is readable, so normalizing them only adds a speed bump when adding new definitions (presuming we enforce it) without major benefit I think.

Can you say more about what motivated this PR?

I don't think we should enforce it, it's just that when writing tests I see 2 different ways of formatting the err annotations. So, I decided to whip up a PR to clean all up with the space as with the examples shown in the aforementioned rustc dev guide. All in all, not really a really strong reason to do so but I prefer it with the space together with uniformity. No strong objections if this is just not worth it, and I can close this PR, thanks.

[Mark-Simulacrum]

I think the cost in both review time (for this PR and future similar PRs) and in churn to git blame isn't worth the very slight delta in possible correlation with the dev guide. I'd be happy to see a PR to the dev-guide noting both work though.

[bors]

☔ The latest upstream changes (presumably #103151) made this pull request unmergeable. Please resolve the merge conflicts.