rustdoc: make the help button a link to a page#103060
Merged
bors merged 4 commits intorust-lang:masterfrom Oct 16, 2022
Merged
Conversation
rustbot
added
the
T-rustdoc
Collaborator
|
Some changes occurred in HTML/CSS themes. A change occurred in the Ayu theme. cc @Cldfire Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
notriddle
force-pushed
the
notridddle/help-page
branch
from
2f339cf to
e41dc6e
Compare
Member
|
I'm not really convinced by this approach but I'll let it up to @jsha. I'm really curious to know what they think about it. Also: if we agree with this, it'll require two new GUI tests:
|
Contributor
|
I haven't looked at the implementation but the idea is good! |
Merged
This allows you to open the help section in a new browser tab, which is a pretty reasonable thing to want for a documentation page.
notriddle
force-pushed
the
notridddle/help-page
branch
from
e41dc6e to
ae4ad9a
Compare
Member
|
Apart from the lint, looks all good to me. Can you regen the online version so we can confirm the help page is rendered correctly too please? |
Contributor
Author
|
@GuillaumeGomez I've changed the appearance of the help page to match the tweaks you made to the settings page.
I've also made a change to both the settings and help event listeners so that holding a modifier key will trigger the browser's default behavior (this way, Ctrl-Click opens a new tab like it should). |
Member
Oh nice! |
GuillaumeGomez
approved these changes
Oct 15, 2022
Member
|
Looks good to me, thanks! @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 15, 2022
…GuillaumeGomez rustdoc: make the help button a link to a page This allows you to open the help section in a new browser tab, which is a pretty reasonable thing to want for a documentation page. Preview: http://notriddle.com/notriddle-rustdoc-demos/help-page/std/index.html
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 15, 2022
…r=notriddle Fix settings page Thanks to rust-lang#103060, I discovered that the settings page was badly rendered. This PR fixes it. Before:  After:  r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 15, 2022
…GuillaumeGomez rustdoc: make the help button a link to a page This allows you to open the help section in a new browser tab, which is a pretty reasonable thing to want for a documentation page. Preview: http://notriddle.com/notriddle-rustdoc-demos/help-page/std/index.html
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 15, 2022
…r=notriddle Fix settings page Thanks to rust-lang#103060, I discovered that the settings page was badly rendered. This PR fixes it. Before:  After:  r? ``@notriddle``
Member
|
Failed in rollup: #103099 (comment) |
bors
added
S-waiting-on-author
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 16, 2022
…r=notriddle Fix settings page Thanks to rust-lang#103060, I discovered that the settings page was badly rendered. This PR fixes it. Before:  After:  r? ```@notriddle```
notriddle
force-pushed
the
notridddle/help-page
branch
from
f0adacf to
8344481
Compare
Contributor
Author
|
Pretty sure I fixed it now with 8344481 |
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 16, 2022
…GuillaumeGomez rustdoc: make the help button a link to a page This allows you to open the help section in a new browser tab, which is a pretty reasonable thing to want for a documentation page. Preview: http://notriddle.com/notriddle-rustdoc-demos/help-page/std/index.html
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2022
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#102857 (Add a regression test for rust-lang#39137) - rust-lang#102953 (Improve docs for `struct_lint_level` function.) - rust-lang#103060 (rustdoc: make the help button a link to a page) - rust-lang#103115 (Clean up anchors.goml rustdoc GUI test) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows you to open the help section in a new browser tab, which is a pretty reasonable thing to want for a documentation page.
Preview: http://notriddle.com/notriddle-rustdoc-demos/help-page/std/index.html