Tidy up maybe_uninit_write_slice API#103130
Tidy up maybe_uninit_write_slice API#103130SUPERCILEX wants to merge 1 commit intorust-lang:masterfrom
Conversation
SUPERCILEX
commented
Oct 17, 2022
- Move methods to extensions
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
r? @scottmcm (rust-highfive has picked a reviewer for you, use r? to override) |
8a3120e to
c547de4
Compare
This comment has been minimized.
This comment has been minimized.
c547de4 to
bf23f29
Compare
This comment has been minimized.
This comment has been minimized.
- Move methods to extensions Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
bf23f29 to
bb55063
Compare
|
Thanks for the PR! While I'm sometimes willing to add new APIs without libs-api assent, I'm much more worried about churning signatures without contacting them to see if they like them, since it would be a shame to find out they didn't and have to revert it and have impacted nightly users unnecessarily. Could you please file an ACP for this set of changes (I think #103128 #103130 #103131 could probably all be one) to get a "yup, that seems better" from the team? @rustbot author |
|
☔ The latest upstream changes (presumably #108538) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@SUPERCILEX any updates on this? |
|
I'm not quite sure what the status is: rust-lang/libs-team#122 (comment) We generally agreed that these slice methods shouldn't exist, but they'll probably be here for a while. I do think that if we end up stabilizing them, it should be like this, not as a static method. The hope would be that they never need to get stabilized though. |
|
See rust-lang/libs-team#122 (comment). These are a bit too heavy weight to become inherent methods. I still think they should be renamed, but that can be discussed before stabilization. |