Remove bounds check when array is indexed by enum#103584
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 1, 2022
Merged
Remove bounds check when array is indexed by enum#103584bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
T-compiler
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Oct 26, 2022
oli-obk
reviewed
Oct 26, 2022
oli-obk
requested changes
Oct 26, 2022
Contributor
oli-obk
left a comment
oli-obk
left a comment
There was a problem hiding this comment.
Please do some manual rustfmting since rustfmt is broken on this file
jackh726
reviewed
Oct 26, 2022
Contributor
Author
Formatted some more, let me know if it's still bad. |
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Oct 28, 2022
Contributor
it is you can just copy your added code into the playground and rustfmt it there and copy it back, I think that should work |
oli-obk
reviewed
Oct 28, 2022
oli-obk
reviewed
Oct 28, 2022
oli-obk
reviewed
Oct 28, 2022
oli-obk
reviewed
Oct 28, 2022
oli-obk
reviewed
Oct 28, 2022
ouz-a
force-pushed
the
issue-102303
branch
2 times, most recently
from
0f6652d to
97c9365
Compare
oli-obk
reviewed
Oct 28, 2022
oli-obk
requested changes
Oct 29, 2022
Contributor
oli-obk
left a comment
oli-obk
left a comment
There was a problem hiding this comment.
After the comments have been addressed, squash all commits
Contributor
|
@bors delegate+ r=me with commits squashed |
Collaborator
|
✌️ @ouz-a can now approve this pull request |
oli-obk
approved these changes
Oct 30, 2022
Contributor
Author
|
@bors r=oli-obk |
Collaborator
|
📌 Commit 689d9d4b426661a2df66ccab014bd2fe76e5cfe0 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
Collaborator
|
☔ The latest upstream changes (presumably #103787) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Contributor
Author
|
@bors r=oli-obk |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 1, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#103061 (Rewrite implementation of `#[alloc_error_handler]`) - rust-lang#103584 (Remove bounds check when array is indexed by enum) - rust-lang#103706 (Fix E0433 No Typo Suggestions) - rust-lang#103729 (interpret: fix align_of_val on packed types) - rust-lang#103759 (Use `adt_def` during type collection.) - rust-lang#103809 (Fix a typo in std::net mod doc comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, this reverts the behavior introduced with 1.64.
Fixes #102303
r? @oli-obk