resolve/effective-visibility: Stop recalculating current normal module

[petrochenkov]

It becomes relatively expensive if done often and shows up during perf profiling

Also drop extern blocks from the effective visibility table, they are nominally private and it doesn't make sense to keep them there.
cc @Bryanskiy

[rustbot]

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

[petrochenkov]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 207c68156a2207984777602b5f8822cf598935ba with merge 05d876bca703933abce2c6894c4d51cbb59b7756...

[bors]

☀️ Try build successful - checks-actions
Build commit: 05d876bca703933abce2c6894c4d51cbb59b7756 (05d876bca703933abce2c6894c4d51cbb59b7756)

[rust-timer]

Queued 05d876bca703933abce2c6894c4d51cbb59b7756 with parent a9ef100, future comparison URL.

[rust-timer]

Finished benchmarking commit (05d876bca703933abce2c6894c4d51cbb59b7756): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-1.4%, -0.2%]	5
Improvements ✅ (secondary)	-1.3%	[-4.0%, -0.3%]	21
All ❌✅ (primary)	-0.7%	[-1.4%, -0.2%]	5

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.0%	[-1.0%, -1.0%]	1
Improvements ✅ (secondary)	-5.1%	[-5.1%, -5.1%]	1
All ❌✅ (primary)	-1.0%	[-1.0%, -1.0%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

[bors]

☔ The latest upstream changes (presumably #103841) made this pull request unmergeable. Please resolve the merge conflicts.

[petrochenkov]

Blocked on #103965.

[petrochenkov]

This change was applied to #104602, closing.