Conversation
Tracking issue: #98407 - const fns now have `rustc_const_unstable` - Added `Generator` forwarding impl - Added `FnOnce` & `FnMut` forwarding impls - Made the `From` impl unstably const
|
(rustbot has picked a reviewer for you, use r? to override) |
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
@rustbot label +T-libs-api -T-libs |
|
☔ The latest upstream changes (presumably #102795) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Hello @h4x5! I noticed that there are some merge conflicts for this PR, what's the status of it? |
|
@anden3 I can resolve the conflicts if a reviewer is interested in merging this |
|
@h4x5 I believe one of the preconditions for getting a review is to not have merge conflicts, so it's probably much easier if you fix those first. |
it would be easier to resolve the conflicts, and then wait for the reviewer to review it when they have the time to. |
#110393 removed all const impls to make it easier to change the way const traits work. Please don't add new const impls for now. |
|
@h4x5 FYI: when a PR is ready for review, send a message containing |
dtolnay
left a comment
There was a problem hiding this comment.
Per #104057 (comment), I don't think the impl<T> const From<T> for Exclusive<T> is something we would accept for now.
The rest of the PR looks good to me.
|
I have extracted the |
Add Exclusive forwarding impls (FnOnce, FnMut, Generator) This is adapted from rust-lang#104057.
Rollup merge of rust-lang#116241 - dtolnay:exclusivefwd, r=Amanieu Add Exclusive forwarding impls (FnOnce, FnMut, Generator) This is adapted from rust-lang#104057.
Tracking issue: #98407
rustc_const_unstableGeneratorforwarding implFnOnce&FnMutforwarding implsFromimpl unstably const