Const Compare for Tuples by onestacked · Pull Request #104125 · rust-lang/rust

onestacked · 2022-11-07T21:05:35Z

Makes the impls for Tuples of ~const PartialEq types also PartialEq, impls for Tuples of ~const PartialOrd types also PartialOrd, for Tuples of ~const Ord types also Ord.

behind the #![feature(const_cmp)] gate.

~~Do not merge before #104113 is merged because I want to use this feature to clean up the new test that I added there.~~

r? @fee1-dead

rustbot · 2022-11-07T21:05:45Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

onestacked · 2022-11-07T21:06:00Z

@rustbot label +T-libs-api -T-libs

fee1-dead · 2022-11-09T02:10:59Z

You should clean up #104113 now.

onestacked · 2022-11-09T09:00:52Z

You should clean up #104113 now.

Done

fee1-dead · 2022-11-09T09:51:16Z

src/test/ui/consts/fn_trait_refs.rs

These asserts don't work unless you put them in a const item, const _: () = {}

They are in const fn main()

they don't work that way

ahh right that only checks that i builds

fee1-dead · 2022-11-09T10:57:19Z

@bors r+ rollup

bors · 2022-11-09T10:57:21Z

📌 Commit b6c05eb has been approved by fee1-dead

It is now in the queue for this repository.

…r=fee1-dead Const Compare for Tuples Makes the impls for Tuples of ~const `PartialEq` types also `PartialEq`, impls for Tuples of ~const `PartialOrd` types also `PartialOrd`, for Tuples of ~const `Ord` types also `Ord`. behind the `#![feature(const_cmp)]` gate. ~~Do not merge before rust-lang#104113 is merged because I want to use this feature to clean up the new test that I added there.~~ r? `@fee1-dead`

Rollup of 7 pull requests Successful merges: - rust-lang#103570 (Stabilize integer logarithms) - rust-lang#103694 (Add documentation examples for `pointer::mask`) - rust-lang#103919 (Unescaping cleanups) - rust-lang#103933 (Promote {aarch64,i686,x86_64}-unknown-uefi to Tier 2) - rust-lang#103952 (Don't intra linkcheck reference) - rust-lang#104111 (rustdoc: Add mutable to the description) - rust-lang#104125 (Const Compare for Tuples) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…r=fee1-dead Const Compare for Tuples Makes the impls for Tuples of ~const `PartialEq` types also `PartialEq`, impls for Tuples of ~const `PartialOrd` types also `PartialOrd`, for Tuples of ~const `Ord` types also `Ord`. behind the `#![feature(const_cmp)]` gate. ~~Do not merge before rust-lang#104113 is merged because I want to use this feature to clean up the new test that I added there.~~ r? ```@fee1-dead```

…r=fee1-dead Const Compare for Tuples Makes the impls for Tuples of ~const `PartialEq` types also `PartialEq`, impls for Tuples of ~const `PartialOrd` types also `PartialOrd`, for Tuples of ~const `Ord` types also `Ord`. behind the `#![feature(const_cmp)]` gate. ~~Do not merge before rust-lang#104113 is merged because I want to use this feature to clean up the new test that I added there.~~ r? ``@fee1-dead``

Rollup of 7 pull requests Successful merges: - rust-lang#103570 (Stabilize integer logarithms) - rust-lang#103694 (Add documentation examples for `pointer::mask`) - rust-lang#103919 (Unescaping cleanups) - rust-lang#103933 (Promote {aarch64,i686,x86_64}-unknown-uefi to Tier 2) - rust-lang#103952 (Don't intra linkcheck reference) - rust-lang#104111 (rustdoc: Add mutable to the description) - rust-lang#104125 (Const Compare for Tuples) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned fee1-dead Nov 7, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 7, 2022

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 7, 2022

onestacked mentioned this pull request Nov 7, 2022

Fix const_fn_trait_ref_impl, add test for it #104113

Merged

const Compare Tuples

f665847

onestacked force-pushed the const_cmp_tuples branch from 2cdff1e to 4f5c6a5 Compare November 9, 2022 08:54

fee1-dead reviewed Nov 9, 2022

View reviewed changes

onestacked force-pushed the const_cmp_tuples branch from 4f5c6a5 to 721b443 Compare November 9, 2022 10:13

Cleanup fn trait ref test

b6c05eb

onestacked force-pushed the const_cmp_tuples branch from 721b443 to b6c05eb Compare November 9, 2022 10:35

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2022

Dylan-DPC mentioned this pull request Nov 9, 2022

Rollup of 7 pull requests #104187

Closed

Dylan-DPC mentioned this pull request Nov 9, 2022

Rollup of 7 pull requests #104192

Merged

Manishearth mentioned this pull request Nov 9, 2022

Rollup of 12 pull requests #104207

Closed

bors merged commit 062f2fc into rust-lang:master Nov 9, 2022

rustbot added this to the 1.67.0 milestone Nov 9, 2022

onestacked deleted the const_cmp_tuples branch February 4, 2023 16:29

fee1-dead added the PG-const-traits Project group: Const traits label Aug 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Const Compare for Tuples#104125

Const Compare for Tuples#104125
bors merged 2 commits intorust-lang:masterfrom
ink-feather-org:const_cmp_tuples

onestacked commented Nov 7, 2022 •

edited

Loading

Uh oh!

rustbot commented Nov 7, 2022

Uh oh!

onestacked commented Nov 7, 2022

Uh oh!

fee1-dead commented Nov 9, 2022

Uh oh!

onestacked commented Nov 9, 2022

Uh oh!

fee1-dead Nov 9, 2022

Uh oh!

onestacked Nov 9, 2022

Uh oh!

fee1-dead Nov 9, 2022

Uh oh!

onestacked Nov 9, 2022

Uh oh!

fee1-dead commented Nov 9, 2022

Uh oh!

bors commented Nov 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

onestacked commented Nov 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 7, 2022

Uh oh!

onestacked commented Nov 7, 2022

Uh oh!

fee1-dead commented Nov 9, 2022

Uh oh!

onestacked commented Nov 9, 2022

Uh oh!

fee1-dead Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

onestacked Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

fee1-dead Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

onestacked Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

fee1-dead commented Nov 9, 2022

Uh oh!

bors commented Nov 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

onestacked commented Nov 7, 2022 •

edited

Loading