Merged
Conversation
On arm, llvm treats the C calling convention as `aapcs` on soft-float targets and `aapcs-vfp` on hard-float targets [1]. UEFI specifies in the arm calling convention that floating point extensions aren't used [2], so always translate `efiapi` to `aapcs` on arm. [1]: rust-lang/compiler-builtins#116 (comment) [2]: https://uefi.org/specs/UEFI/2.10/02_Overview.html#detailed-calling-convention rust-lang#65815
…i-obk Add loongarch64 abi support
…wesleywiser Use `TraitEngine` in more places, restrict visibility of `FulfillmentCtxt` constructor Most places that are constructing a `FulfillmentContext` should be constructing a `TraitEngine` generically, so later on if/when we're transitioning it'll be easier. Logical extension of rust-lang#99746
…rochenkov Suggest `is_some` when we've found `Option` but expected `bool` Thanks `@lunasorcery` for the suggestion.
…-dead Make `Hash`, `Hasher` and `BuildHasher` `#[const_trait]` and make `Sip` const `Hasher` This PR enables using Hashes in const context. r? ``@fee1-dead``
…r=nagisa Use aapcs for efiapi calling convention on arm On arm, [llvm treats the C calling convention as `aapcs` on soft-float targets and `aapcs-vfp` on hard-float targets](rust-lang/compiler-builtins#116 (comment)). UEFI specifies in the arm calling convention that [floating point extensions aren't used](https://uefi.org/specs/UEFI/2.10/02_Overview.html#detailed-calling-convention), so always translate `efiapi` to `aapcs` on arm. rust-lang#65815
…inding-issue, r=oli-obk Tighten the 'introduce new binding' suggestion Fixes rust-lang#104086
…ler-errors `EarlyBinder` docs
Don't ICE when encountering `ConstKind::Error` in `RequiredConstsVisitor` Fixes rust-lang#104209
…i-obk Use `const_error_with_guaranteed` more Better to pass down an ErrorGuaranteed rather than making a new one out of thin air, for some usages. Also for the ones where we *do* need to delay a bug, that delayed bug will have a more descriptive message.
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ p=5 rollup=never |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: 01a6f30324 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Nov 10, 2022
Merged
Collaborator
|
Finished benchmarking commit (a3c0a02): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
TraitEnginein more places, restrict visibility ofFulfillmentCtxtconstructor #103863 (UseTraitEnginein more places, restrict visibility ofFulfillmentCtxtconstructor)is_somewhen we've foundOptionbut expectedbool#104036 (Suggestis_somewhen we've foundOptionbut expectedbool)Hash,HasherandBuildHasher#[const_trait]and makeSipconstHasher#104060 (MakeHash,HasherandBuildHasher#[const_trait]and makeSipconstHasher)EarlyBinderdocs #104194 (EarlyBinderdocs)ConstKind::ErrorinRequiredConstsVisitor#104233 (Don't ICE when encounteringConstKind::ErrorinRequiredConstsVisitor)const_error_with_guaranteedmore #104235 (Useconst_error_with_guaranteedmore)Failed merges:
:targetrules to use CSS variables #104169 (Migrate:targetrules to use CSS variables)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup